From 8606e26f3165f4ccf323e4ac3f1bdb053eae5494 Mon Sep 17 00:00:00 2001 From: alokkumardalei-wq Date: Fri, 10 Apr 2026 14:11:35 +0530 Subject: [PATCH 1/3] Clarify post-route antenna repair metrics Signed-off-by: alokkumardalei-wq --- flow/scripts/detail_route.tcl | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/flow/scripts/detail_route.tcl b/flow/scripts/detail_route.tcl index c3503558f6..424159a191 100644 --- a/flow/scripts/detail_route.tcl +++ b/flow/scripts/detail_route.tcl @@ -57,15 +57,22 @@ if { !$::env(SKIP_ANTENNA_REPAIR_POST_DRT) && [env_var_exists_and_non_empty MAX_REPAIR_ANTENNAS_ITER_DRT] } { - set repair_antennas_iters 1 - if { [repair_antennas] } { - detailed_route {*}$all_args - } + set repair_antennas_iters 0 + set repair_antennas_count -1 + utl::set_metrics_stage "detailedroute__drt__repair_antennas__pre_repair__{}" while { [check_antennas] && $repair_antennas_iters < $::env(MAX_REPAIR_ANTENNAS_ITER_DRT) } { - repair_antennas + utl::set_metrics_stage "detailedroute__drt__repair_antennas__iter_${repair_antennas_iters}__{}" + set repair_antennas_count [repair_antennas] detailed_route {*}$all_args incr repair_antennas_iters } + utl::set_metrics_stage "detailedroute__{}" + if { $repair_antennas_count == -1 } { + # Preserve the top-level diode count metric even when no post-DRT repair is needed. + repair_antennas + } else { + utl::metric_int "antenna_diodes_count" $repair_antennas_count + } } else { utl::metric_int "antenna_diodes_count" -1 } From d1068de3ce95bf1cce1b8109ed60b962e93c31a6 Mon Sep 17 00:00:00 2001 From: alokkumardalei-wq Date: Sat, 11 Apr 2026 14:36:15 +0530 Subject: [PATCH 2/3] ci: retrigger jenkins Signed-off-by: alokkumardalei-wq From 588300856c16b2915a48c73831f8dc7535f58345 Mon Sep 17 00:00:00 2001 From: alokkumardalei-wq Date: Fri, 17 Apr 2026 17:53:16 +0530 Subject: [PATCH 3/3] Use push/pop metrics stage for antenna repair iterations Address review feedback: replace set_metrics_stage with push/pop_metrics_stage for antenna repair sub-stages to follow the stack-based convention (matching cts.tcl pattern). This avoids jumping back to detailedroute__{} and preserves the existing detailedroute__antenna_diodes_count metric key. Signed-off-by: alokkumardalei-wq --- flow/scripts/detail_route.tcl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/flow/scripts/detail_route.tcl b/flow/scripts/detail_route.tcl index 424159a191..058f3cce52 100644 --- a/flow/scripts/detail_route.tcl +++ b/flow/scripts/detail_route.tcl @@ -59,14 +59,15 @@ if { } { set repair_antennas_iters 0 set repair_antennas_count -1 - utl::set_metrics_stage "detailedroute__drt__repair_antennas__pre_repair__{}" + utl::push_metrics_stage "detailedroute__{}__pre_repair" while { [check_antennas] && $repair_antennas_iters < $::env(MAX_REPAIR_ANTENNAS_ITER_DRT) } { - utl::set_metrics_stage "detailedroute__drt__repair_antennas__iter_${repair_antennas_iters}__{}" + utl::push_metrics_stage "detailedroute__{}__repair_iter_${repair_antennas_iters}" set repair_antennas_count [repair_antennas] detailed_route {*}$all_args + utl::pop_metrics_stage incr repair_antennas_iters } - utl::set_metrics_stage "detailedroute__{}" + utl::pop_metrics_stage if { $repair_antennas_count == -1 } { # Preserve the top-level diode count metric even when no post-DRT repair is needed. repair_antennas