password-less-authentication-ui-completed #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
please add "serviceAccountKey.js" in .gitignore file |
Contributor
|
please do not commit package-lock.json changes because you haven't added any new library |
Member
Author
serviceAccountKey is already in .gitignore i.e "backend/firebase/serviceAccountKey.json" |
Contributor
|
change "backend/firebase/serviceAccountKey.json" to "backend/firebase/serviceAccountKey.js" |
hamza-akram
commented
Jun 11, 2021
Member
Author
hamza-akram
left a comment
hamza-akram
left a comment
There was a problem hiding this comment.
Please review, develop a dynamic component for send and verify process.
Contributor
|
@hamza-akram please do not commit backend/firebase/serviceAccountKey.js |
Contributor
|
@hamza-akram please remove PR conflicts |
Contributor
|
please do not commit frontend/package-lock.json if you have not added any new npm package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Password less authentication ui is completed, please review.