Skip to content

Conversation

@dikadk
Copy link
Collaborator

@dikadk dikadk commented Nov 17, 2025

Changes default behaviour of choc_DesktopWindow Dock Icon.
It will no longer show up by default, when DesktopWindow is created.

MacOS - NSApplicationActivationPolicyRegular -> NSApplicationActivationPolicyAccessory
Win - hwnd = HWNDHolder (CreateWindowExW (WS_EX_TOOLWINDOW,
windowClass.getClassName(),
L"",
WS_OVERLAPPEDWINDOW,

@dikadk dikadk changed the title Hide desktop window icon from the Dock and adjust window creation par… Hide desktop window icon from the Dock and adjust window creation parameters Nov 17, 2025
@dikadk dikadk force-pushed the hideDesktopWindowIcon branch from d6f9f4a to f40c15f Compare November 17, 2025 15:48
Copy link

@mike-malburg mike-malburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough context to know if this is an appropriate fix or not? Can you please include testing steps either here or in the CommonCpp PR that indicate:

  1. What is the undesired behavior we are experiencing before this fix?
  2. What is the new desired behavior that occurs after we include this fix?

I think others, or even "future-us" will thank ourselves if we document this somewhere 🙂. Maybe we can get the change upstreamed at some point if this is something that would be desired for other contributors to this library?

Also, it appears this repo is public. While this is required of LGPL libraries, I'm not sure that this is required with ISC licensed libraries? Do we want to make this public, going forward?

Copy link

@mike-malburg mike-malburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me. I did not test this in-product, but is building and passing all automated tests in CommonCpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants