Skip to content

Commit b1ae6c9

Browse files
committed
From test projects removed a .NET Core App 1.0 target
1 parent e801791 commit b1ae6c9

File tree

13 files changed

+8
-535
lines changed

13 files changed

+8
-535
lines changed

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"sdk": {
3-
"version": "3.1.101"
3+
"version": "3.1.411"
44
}
55
}

test/MsieJavaScriptEngine.Test.Auto/MsieJavaScriptEngine.Test.Auto.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
<PropertyGroup>
44
<Product>MSIE JavaScript Engine: Tests for Auto Mode</Product>
55
<VersionPrefix>3.0.7</VersionPrefix>
6-
<TargetFrameworks>net40;net451;netcoreapp1.0;netcoreapp2.1;netcoreapp3.1</TargetFrameworks>
7-
<RuntimeFrameworkVersion Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">1.0.16</RuntimeFrameworkVersion>
6+
<TargetFrameworks>net40;net451;netcoreapp2.1;netcoreapp3.1</TargetFrameworks>
87
<OutputType>Library</OutputType>
98
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
109
<IsTestProject>true</IsTestProject>

test/MsieJavaScriptEngine.Test.ChakraEdgeJsRt/MsieJavaScriptEngine.Test.ChakraEdgeJsRt.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
<PropertyGroup>
44
<Product>MSIE JavaScript Engine: Tests for Chakra Edge JsRT Mode</Product>
55
<VersionPrefix>3.0.7</VersionPrefix>
6-
<TargetFrameworks>net40;net451;netcoreapp1.0;netcoreapp2.1;netcoreapp3.1</TargetFrameworks>
7-
<RuntimeFrameworkVersion Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">1.0.16</RuntimeFrameworkVersion>
6+
<TargetFrameworks>net40;net451;netcoreapp2.1;netcoreapp3.1</TargetFrameworks>
87
<OutputType>Library</OutputType>
98
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
109
<IsTestProject>true</IsTestProject>

test/MsieJavaScriptEngine.Test.ChakraEdgeJsRt/PrecompilationTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ public void GenerationOfCompilationErrorMessageIsCorrect()
127127
charIndex
128128
;
129129
130-
for (charIndex = 0; charIndex < length; charIndex++)
130+
for (charIndex = 0; charIndex < length; charIndex++)
131131
result += possible.charAt(Math.floor(Math.random() * possible.length));
132132
}
133133

test/MsieJavaScriptEngine.Test.ChakraIeJsRt/MsieJavaScriptEngine.Test.ChakraIeJsRt.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
<PropertyGroup>
44
<Product>MSIE JavaScript Engine: Tests for Chakra IE JsRT Mode</Product>
55
<VersionPrefix>3.0.7</VersionPrefix>
6-
<TargetFrameworks>net40;net451;netcoreapp1.0;netcoreapp2.1;netcoreapp3.1</TargetFrameworks>
7-
<RuntimeFrameworkVersion Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">1.0.16</RuntimeFrameworkVersion>
6+
<TargetFrameworks>net40;net451;netcoreapp2.1;netcoreapp3.1</TargetFrameworks>
87
<OutputType>Library</OutputType>
98
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
109
<IsTestProject>true</IsTestProject>

test/MsieJavaScriptEngine.Test.ChakraIeJsRt/PrecompilationTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public void GenerationOfCompilationErrorMessageIsCorrect()
126126
charIndex
127127
;
128128
129-
for (charIndex = 0; charIndex < length; charIndex++)
129+
for (charIndex = 0; charIndex < length; charIndex++)
130130
result += possible.charAt(Math.floor(Math.random() * possible.length));
131131
}
132132

test/MsieJavaScriptEngine.Test.Common/FileSystemTestsBase.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
using System;
22
using System.IO;
3-
#if NETCOREAPP1_0
4-
5-
using Microsoft.Extensions.PlatformAbstractions;
6-
#endif
73

84
namespace MsieJavaScriptEngine.Test.Common
95
{
@@ -14,12 +10,7 @@ public abstract class FileSystemTestsBase : TestsBase
1410

1511
protected FileSystemTestsBase()
1612
{
17-
#if NETCOREAPP1_0
18-
var appEnv = PlatformServices.Default.Application;
19-
string appDirectoryPath = appEnv.ApplicationBasePath;
20-
#else
2113
string appDirectoryPath = AppDomain.CurrentDomain.BaseDirectory;
22-
#endif
2314
_baseDirectoryPath = Path.Combine(appDirectoryPath, "../../../../");
2415
}
2516

0 commit comments

Comments
 (0)