Added support of identifier names compliant with ECMAScript 5

Author: Taritsyn

NuGet/MsieJavaScriptEngine.nuspec

@@ -15,7 +15,8 @@
 		<releaseNotes>1. In JsRT modes fixed a problems in calculation of error locations;
 2. An attempt was made to prevent occurrence of the access violation exception;
 3. Now the original exception is added to instance of the `JsRuntimeException` class as an inner exception;
-4. An attempt was made to prevent a blocking of finalizer's thread.</releaseNotes>
+4. An attempt was made to prevent a blocking of finalizer's thread;
+5. Added support of identifier names compliant with ECMAScript 5.</releaseNotes>
 		<copyright>Copyright (c) 2012-2017 Andrey Taritsyn - http://www.taritsyn.ru</copyright>
 		<language>en-US</language>
 		<tags>JavaScript ECMAScript MSIE IE Edge Chakra</tags>

NuGet/readme.txt

@@ -25,7 +25,8 @@
    2. An attempt was made to prevent occurrence of the access violation exception;
    3. Now the original exception is added to instance of the `JsRuntimeException`
       class as an inner exception;
-   4. An attempt was made to prevent a blocking of finalizer's thread.
+   4. An attempt was made to prevent a blocking of finalizer's thread;
+   5. Added support of identifier names compliant with ECMAScript 5.
 
    ============
    PROJECT SITE

src/MsieJavaScriptEngine/Helpers/ValidationHelpers.cs

@@ -20,9 +20,10 @@ public static class ValidationHelpers
 		};
 
 		/// <summary>
-		/// Regular expression for working with JS-names
+		/// Regular expression for working with JS names
 		/// </summary>
-		private static readonly Regex _jsNameRegex = new Regex(@"^[A-Za-z_\$][0-9A-Za-z_\$]*$");
+		private static readonly Regex _jsNameRegex = new Regex(@"^[$_\p{Lu}\p{Ll}\p{Lt}\p{Lm}\p{Lo}\p{Nl}]" +
+			@"[$_\p{Lu}\p{Ll}\p{Lt}\p{Lm}\p{Lo}\p{Nl}\u200C\u200D\p{Mn}\p{Mc}\p{Nd}\p{Pc}]*$");
 
 
 		/// <summary>

test/MsieJavaScriptEngine.Test.Common/CommonTestsBase.cs

@@ -847,6 +847,40 @@ public virtual void SettingAndGettingVariableWithUnicodeStringValueIsCorrect()
 			Assert.AreEqual(input2, output2);
 		}
 
+		[Test]
+		public virtual void SettingAndGettingVariableWithNameContainingUnicodeCharactersIsCorrect()
+		{
+			// Arrange
+			const string variableName = "слово";
+
+			const string input1 = "Hip-hip Hooray";
+			const string targetOutput1 = "Hip-hip Hooray!";
+
+			const string input2 = "Hip-hip Hurrah";
+
+			// Act
+			bool variableExists;
+			string output1;
+			string output2;
+
+			using (var jsEngine = CreateJsEngine())
+			{
+				jsEngine.SetVariableValue(variableName, input1);
+				variableExists = jsEngine.HasVariable(variableName);
+				jsEngine.Execute(string.Format("{0} += '!';", variableName));
+				output1 = jsEngine.GetVariableValue<string>(variableName);
+
+				jsEngine.SetVariableValue(variableName, input2);
+				output2 = jsEngine.GetVariableValue<string>(variableName);
+			}
+
+			// Assert
+			Assert.True(variableExists);
+			Assert.AreEqual(targetOutput1, output1);
+
+			Assert.AreEqual(input2, output2);
+		}
+
 		[Test]
 		public virtual void RemovingVariableIsCorrect()
 		{

test/MsieJavaScriptEngine.Test.Common/ValidationTests.cs

@@ -18,13 +18,15 @@ public void NameFormatIsCorrect()
 			bool name3FormatIsCorrect = ValidationHelpers.CheckNameFormat("fooBar");
 			bool name4FormatIsCorrect = ValidationHelpers.CheckNameFormat("$grid");
 			bool name5FormatIsCorrect = ValidationHelpers.CheckNameFormat("a");
+			bool name6FormatIsCorrect = ValidationHelpers.CheckNameFormat("À_la_maison");
 
 			// Assert
 			Assert.IsTrue(name1FormatIsCorrect);
 			Assert.IsTrue(name2FormatIsCorrect);
 			Assert.IsTrue(name3FormatIsCorrect);
 			Assert.IsTrue(name4FormatIsCorrect);
 			Assert.IsTrue(name5FormatIsCorrect);
+			Assert.IsTrue(name6FormatIsCorrect);
 		}
 
 		[Test]