From a83dba36738bedd4420fd69e106bc795fb04a0d4 Mon Sep 17 00:00:00 2001 From: Kevin Van Cott Date: Mon, 24 Aug 2026 20:54:14 -0500 Subject: [PATCH 1/2] docs: clarify contribution guidelines --- .coderabbit.yaml | 12 ++++++++++++ .github/pull_request_template.md | 3 ++- AGENTS.md | 10 ++++++++++ CONTRIBUTING.md | 18 ++++++++++++++++++ 4 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 .coderabbit.yaml create mode 100644 AGENTS.md diff --git a/.coderabbit.yaml b/.coderabbit.yaml new file mode 100644 index 00000000..59147a93 --- /dev/null +++ b/.coderabbit.yaml @@ -0,0 +1,12 @@ +# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json + +reviews: + request_changes_workflow: false + slop_detection: + enabled: true + +knowledge_base: + code_guidelines: + enabled: true + filePatterns: + - "CONTRIBUTING.md" diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 04aa6abf..46923a6a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -5,7 +5,8 @@ ## ✅ Checklist - [ ] I have followed the steps in the [Contributing guide](https://github.com/TanStack/store/blob/main/CONTRIBUTING.md). -- [ ] I have tested this code locally with `pnpm test:pr`. +- [ ] I have tested code changes locally with `pnpm test:pr`, or these tests do not apply to this pull request. +- [ ] I fully understand the code in this pull request, including any code generated with AI assistance. ## 🚀 Release Impact diff --git a/AGENTS.md b/AGENTS.md new file mode 100644 index 00000000..af9e3543 --- /dev/null +++ b/AGENTS.md @@ -0,0 +1,10 @@ +# Agent Instructions + +Before analyzing or changing this repository, read and follow +[`CONTRIBUTING.md`](./CONTRIBUTING.md). Its contribution, development, testing, +pull request, and changeset requirements apply to AI-assisted work as well as +human-authored work. + +Keep every change focused on one topic. Understand and verify all generated +code, run the required checks, and provide a concise pull request description +that follows the repository template. diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b37a19a7..4ee52fc4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,5 +1,23 @@ # Contributing +## Before You Start + +- Search the [open and closed issues](https://github.com/TanStack/store/issues?q=is%3Aissue) before reporting a bug. If it has not already been reported, use the [bug report template](https://github.com/TanStack/store/issues/new?template=bug_report.yml). +- Search the [open and closed pull requests](https://github.com/TanStack/store/pulls?q=is%3Apr) before starting work to avoid duplicating an existing contribution. +- Discuss significant features, API changes, and refactors with the maintainers in an issue before implementing them. + +## Pull Request Guidelines + +Every pull request must follow the [TanStack Store pull request template](.github/pull_request_template.md). Complete its description and checklist without removing or bypassing the required sections. + +- Keep each pull request focused on one change or topic. Pull requests that combine unrelated changes will be closed with a request to split them into separately reviewable contributions. +- Write a concise description that clearly explains what changed and why. Follow the sections in the pull request template; a long, unstructured description makes a contribution harder to review. +- You may use AI tools to help generate code, but you remain responsible for understanding, testing, and verifying every submitted change. Do not submit unreviewed, low-quality, or irrelevant generated code. +- Do not mass-submit unrelated or low-quality AI-generated pull requests. We treat that behavior as spam and may close the pull requests, block the contributor, and report the GitHub account. +- Every change that affects a published package must include a changeset. Create it with `pnpm changeset`; documentation, CI, and development-only changes do not require one. + +## Development Workflow + - Clone the repo - `gh repo clone TanStack/store` - Ensure `node` is installed From d008cfc05e355dd5fb8679d574c1c080260a93f7 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Tue, 25 Aug 2026 01:56:37 +0000 Subject: [PATCH 2/2] ci: apply automated fixes and generate docs --- .coderabbit.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 59147a93..21d884db 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -9,4 +9,4 @@ knowledge_base: code_guidelines: enabled: true filePatterns: - - "CONTRIBUTING.md" + - 'CONTRIBUTING.md'