From fcbb8dbc845e90310af009152706657b02df5097 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Tue, 29 Sep 2026 12:04:23 +0900 Subject: [PATCH] chore(*): remove unused 'react' packages from the root and scope the knip '@types/react' ignore to the packages that need it --- knip.ts | 18 +++++++++++------- package.json | 4 ---- pnpm-lock.yaml | 12 ------------ 3 files changed, 11 insertions(+), 23 deletions(-) diff --git a/knip.ts b/knip.ts index e5eafab09c..2e962f87e2 100644 --- a/knip.ts +++ b/knip.ts @@ -5,13 +5,7 @@ export default { ignore: ['scripts/*.{j,t}s', '**/ts-fixture/file.ts'], treatConfigHintsAsErrors: true, treatTagHintsAsErrors: true, - ignoreDependencies: [ - '@oxc-project/runtime', - '@types/react', - '@types/react-dom', - 'react', - 'react-dom', - ], + ignoreDependencies: ['@oxc-project/runtime'], ignoreWorkspaces: ['examples/**', 'integrations/**'], rules: { duplicates: 'warn' }, workspaces: { @@ -27,6 +21,16 @@ export default { entry: ['src/v4/**/*.cjs', 'src/v5/**/*.cjs'], ignore: ['**/__testfixtures__/**'], }, + // Built types import 'react', which the consumer's '@types/react' provides. + 'packages/react-query': { + ignoreDependencies: ['@types/react!'], + }, + 'packages/react-query-next-experimental': { + ignoreDependencies: ['@types/react!'], + }, + 'packages/react-query-persist-client': { + ignoreDependencies: ['@types/react!'], + }, 'packages/vue-query': { ignoreDependencies: ['vue2', 'vue2.7'], }, diff --git a/package.json b/package.json index 1028f50445..a0d8a7fec7 100644 --- a/package.json +++ b/package.json @@ -57,8 +57,6 @@ "@tanstack/typedoc-config": "0.3.1", "@testing-library/jest-dom": "^6.8.0", "@types/node": "^22.15.3", - "@types/react": "catalog:", - "@types/react-dom": "catalog:", "@vitest/coverage-istanbul": "4.1.11", "@vitest/eslint-plugin": "^1.6.27", "eslint": "^9.36.0", @@ -71,8 +69,6 @@ "prettier": "^3.9.9", "prettier-plugin-svelte": "^4.1.1", "publint": "^0.3.24", - "react": "catalog:", - "react-dom": "catalog:", "sherif": "^1.13.0", "size-limit": "^14.0.0", "tinyglobby": "^0.2.15", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index aa864af990..42e874c66a 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -278,12 +278,6 @@ importers: '@types/node': specifier: ^22.15.3 version: 22.19.15 - '@types/react': - specifier: ^19.2.7 - version: 19.2.14 - '@types/react-dom': - specifier: ^19.2.3 - version: 19.2.3(@types/react@19.2.14) '@vitest/coverage-istanbul': specifier: 4.1.11 version: 4.1.11(supports-color@7.2.0)(vitest@4.1.11) @@ -320,12 +314,6 @@ importers: publint: specifier: ^0.3.24 version: 0.3.24 - react: - specifier: 'catalog:' - version: 19.2.4 - react-dom: - specifier: 'catalog:' - version: 19.2.4(react@19.2.4) sherif: specifier: ^1.13.0 version: 1.13.0