form.validateAllFields became not work from 1.0.0 (regression)

[viktor-galytskyi]

Describe the bug

const validationErrors: ValidationError[] = await form.validateAllFields('submit');
return empty ValidationError array even if some fields are not valid.

in a screenshot, there are two places with "calculation[0].name" validation data.

1. state.errors (error present)
2. fieldMeta (no error, Why?)

Field "...name" is not valid, but fieldMeta without an error.

3. isFieldsValid: true but errors array not empty

Your minimal, reproducible example

code

Steps to reproduce

define form.
Make some fields not valid.
Trigger await form.handleSubmit();
Take a look at validationErrors: ValidationError[];

const handleSave = async (form) => {
await form.handleSubmit();

const validationErrors: ValidationError[] = await form.validateAllFields('submit');

console.log('form', form);

};

Expected behavior

1. form.validateAllFields('submit'); should return errors
2. fiealdMeta should be marked as not valid in the correspondent field
3. isFieldsValid* should be false in case form fields not valid.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

• MacOS (last)
• Chrome (last)

TanStack Form adapter

react-form

TanStack Form version

1.0.0

TypeScript version

No response

Additional context

No response

[crutchcorn]

You mentioned this was a regression - from which version?

[viktor-galytskyi]

@crutchcorn
0.41.0 was good

[crutchcorn]

I can't reproduce this error. It's working for me. Please include a minimal reproduction error.

[Davit-000]

having same issue from version 1.1.2

[literalpie]

I think this is a minimal example: https://stackblitz.com/edit/vitejs-vite-obprn36n?file=src%2FApp.tsx&terminal=dev

[harry-whorlow]

Okay, so I think this stems from a misunderstanding of the method.

• form.validateAllFields() validates from the field level validators only, it will not account for form level validators.
• form.validate() will account for form level validators

This will error with form.validateAllFields()

<form.Field
    name="firstName"
    validators={{
       onSubmit: ({ value }) => (value.length > 0 ? undefined : 'is required'),
    }}
    children={(field) => {
      return (
        <input
          id={field.name}
          name={field.name}
          value={field.state.value}
          onBlur={field.handleBlur}
          onChange={(e) => field.handleChange(e.target.value)}
        />
      )
    }}
  />

this will not

const form = new FormApi({
    defaultValues: {
      firstName: '',
      lastName: '',
    },
    validators: {
      onSubmit: ({ value }) => {
        return {
          fields: {
            firstName: value.firstName.length > 0 ? undefined : 'is required',
          },
        }
      },
    },
  })

I've updated the description #2117

[harry-whorlow]

I'm going to close this issue, if it persists or you think I'm wrong in my assessment please reopen it 😊