Skip to content

Commit 0f1535c

Browse files
Chore/revert issue with panel (#308)
* revert panel issue * changeset * fixup for the panel classes * ci: apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
1 parent aaeb590 commit 0f1535c

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

.changeset/neat-peaches-matter.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@tanstack/devtools-utils': patch
3+
---
4+
5+
fix: panel issue fix

.changeset/thin-pianos-rhyme.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@tanstack/devtools-utils': patch
3+
---
4+
5+
revert panel generation

packages/devtools-utils/src/preact/panel.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ export function createPreactPanel<
3434
const devToolRef = useRef<HTMLDivElement>(null)
3535
const devtools = useRef<TCoreDevtoolsClass | null>(null)
3636
useEffect(() => {
37-
if (devtools.current) return
38-
3937
devtools.current = new CoreClass()
4038

4139
if (devToolRef.current) {
@@ -45,6 +43,7 @@ export function createPreactPanel<
4543
return () => {
4644
if (devToolRef.current) {
4745
devtools.current?.unmount()
46+
devtools.current = null
4847
}
4948
}
5049
}, [props?.theme])

packages/devtools-utils/src/react/panel.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ export function createReactPanel<
3232
const devToolRef = useRef<HTMLDivElement>(null)
3333
const devtools = useRef<TCoreDevtoolsClass | null>(null)
3434
useEffect(() => {
35-
if (devtools.current) return
36-
3735
devtools.current = new CoreClass()
3836

3937
if (devToolRef.current) {
@@ -43,6 +41,7 @@ export function createReactPanel<
4341
return () => {
4442
if (devToolRef.current) {
4543
devtools.current?.unmount()
44+
devtools.current = null
4645
}
4746
}
4847
}, [props?.theme])

0 commit comments

Comments
 (0)