fix(react-db): make getNextPageParam optional in useLiveInfiniteQuery#1268
Open
sleitor wants to merge 2 commits intoTanStack:mainfrom
Open
fix(react-db): make getNextPageParam optional in useLiveInfiniteQuery#1268sleitor wants to merge 2 commits intoTanStack:mainfrom
sleitor wants to merge 2 commits intoTanStack:mainfrom
Conversation
getNextPageParam is required in UseLiveInfiniteQueryConfig but is never called — pagination is determined entirely by the peek-ahead strategy. Mark it as optional with a @deprecated JSDoc tag so consumers aren't forced to write dead code. Fixes TanStack#1241
🦋 Changeset detectedLatest commit: 5f6e958 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getNextPageParamis required inUseLiveInfiniteQueryConfigbut is never called anywhere in the implementation. Pagination is determined entirely by the peek-ahead strategy (dataArray.length > totalItemsRequested).This forces every consumer to write a callback that has zero effect on behavior.
Change
Mark
getNextPageParamas optional (?) with a@deprecatedJSDoc tag explaining that pagination is handled internally.This is a non-breaking change — existing code that passes
getNextPageParamcontinues to work; code that omits it no longer gets a type error.Fixes #1241