v 1.1.12

Author: Maximilian Karl

docs/changes.rst

@@ -93,4 +93,9 @@ Version 1.1.11 (July 29, 2021)
 -----------------------------------
 
 * change define unknown user in Utility!
-* users can now be referenced with uuids from other users or a new user will be created
+* users can now be referenced with uuids from other users or a new user will be created
+
+Version 1.1.12 (July 29, 2021)
+-----------------------------------
+
+* solved error: check for numpy is nan in Utility

github2pandas/__init__.py

@@ -1 +1 @@
-__version__ = '1.1.11'
+__version__ = '1.1.12'

github2pandas/utility.py

@@ -701,7 +701,7 @@ def define_unknown_user(user_dict, unknown_user, data_root_dir):
                 alias = ""
                 user = p_user.iloc[0]
                 if "alias" in user:
-                    if (user["alias"] == numpy.NAN) or (user["alias"] is None):
+                    if numpy.isnan(user["alias"]) or (user["alias"] is None):
                         alias = unknown_user
                     else:
                         alias = user["alias"] + ";" + unknown_user

tests/test_utility.py

@@ -287,6 +287,23 @@ class Comment:
         self.assertIsNotNone(comment_data)
         self.assertFalse("author" in comment_data.keys())
 
+    def test_define_unknown_user(self):
+        class User:
+             node_id = "test_define_unknown_user"
+             name = "test_define_unknown_user"
+             email = "test_define_unknown_user@test.de"
+             login = "test_define_unknown_user"
+        user = Utility.extract_user_data(User(), self.users_ids, self.default_data_folder)
+        new_user = Utility.define_unknown_user({"test":user},"test",self.default_data_folder)
+        class User2:
+             node_id = "test_define_unknown_user2"
+             name = "test_define_unknown_use2r"
+             email = "test_define_unknown_user2@test.de"
+             login = "test_define_unknown_user2"
+        user2 = Utility.extract_user_data(User2(), self.users_ids, self.default_data_folder)
+        new_user = Utility.define_unknown_user({"test2":user2},"test2",self.default_data_folder)
+        print(Utility.get_users(self.default_data_folder))
+
     def setUp(self):
         self.default_data_folder.mkdir(parents=True, exist_ok=True)