feat: use dispatch version instead of immutable list

Author: MilesCranmer

src/DynamicExpressions.jl

@@ -67,6 +67,7 @@ import .NodeModule:
     get_scalar_constants,
     set_scalar_constants!
 @reexport import .StringsModule: string_tree, print_tree
+import .StringsModule: get_op_name
 @reexport import .OperatorEnumModule: AbstractOperatorEnum
 @reexport import .OperatorEnumConstructionModule:
     OperatorEnum, GenericOperatorEnum, @extend_operators, set_default_variable_names!

src/Strings.jl

@@ -4,16 +4,6 @@ using ..UtilsModule: deprecate_varmap
 using ..OperatorEnumModule: AbstractOperatorEnum
 using ..NodeModule: AbstractExpressionNode, tree_mapreduce
 
-const OP_NAMES = Base.ImmutableDict(
-    "safe_log" => "log",
-    "safe_log2" => "log2",
-    "safe_log10" => "log10",
-    "safe_log1p" => "log1p",
-    "safe_acosh" => "acosh",
-    "safe_sqrt" => "sqrt",
-    "safe_pow" => "^",
-)
-
 function dispatch_op_name(::Val{deg}, ::Nothing, idx)::Vector{Char} where {deg}
     if deg == 1
         return vcat(collect("unary_operator["), collect(string(idx)), [']'])

test/test_params.jl

@@ -1,4 +1,5 @@
 using DynamicExpressions
+import DynamicExpressions as DE
 
 maximum_residual = 1e-2
 
@@ -26,6 +27,13 @@ maximum_residual = 1e-2
     greater(x, y) = (x > y)
 
     custom_cos(x) = cos(x)^2
+
+    DE.get_op_name(::typeof(safe_log)) = ['l', 'o', 'g']
+    DE.get_op_name(::typeof(safe_log2)) = ['l', 'o', 'g', '2']
+    DE.get_op_name(::typeof(safe_log10)) = ['l', 'o', 'g', '1', '0']
+    DE.get_op_name(::typeof(safe_log1p)) = ['l', 'o', 'g', '1', 'p']
+    DE.get_op_name(::typeof(safe_acosh)) = ['a', 'c', 'o', 's', 'h']
+    DE.get_op_name(::typeof(safe_sqrt)) = ['s', 'q', 'r', 't']
 end
 
 HEADER_GUARD_TEST_PARAMS = true

test/test_print.jl

@@ -1,5 +1,6 @@
 using Test
 using DynamicExpressions
+import DynamicExpressions as DE
 import Compat: Returns
 
 include("test_params.jl")
@@ -32,8 +33,10 @@ for unaop in [safe_log, safe_log2, safe_log10, safe_log1p, safe_sqrt, safe_acosh
     @test string_tree(minitree, opts) == replace(string(unaop), "safe_" => "") * "(x1)"
 end
 
-!(@isdefined safe_pow) &&
-    @eval safe_pow(x::T, y::T) where {T<:Number} = (x < 0 && y != round(y)) ? T(NaN) : x^y
+@isdefined(safe_pow) || @eval begin
+    safe_pow(x::T, y::T) where {T<:Number} = (x < 0 && y != round(y)) ? T(NaN) : x^y
+    DE.get_op_name(::typeof(safe_pow)) = ['^']
+end
 for binop in [safe_pow, ^]
     opts = OperatorEnum(;
         default_params..., binary_operators=(+, *, /, -, binop), unary_operators=(cos,)