Fix type inference in bumper eval

Author: MilesCranmer

ext/DynamicExpressionsBumperExt.jl

@@ -11,7 +11,8 @@ function bumper_eval_tree_array(
 ) where {T}
     result = similar(cX, axes(cX, 2))
     n = size(cX, 2)
-    ok = @no_escape begin
+    all_ok = Ref(false)
+    @no_escape begin
         _result_ok = tree_mapreduce(
             # Leaf nodes, we create an allocation and fill
             # it with the value of the leaf:
@@ -37,9 +38,9 @@ function bumper_eval_tree_array(
         )
         x = _result_ok.x
         result .= x
-        _result_ok.ok
+        all_ok[] = _result_ok.ok
     end
-    return (result, ok)
+    return (result, all_ok[])
 end
 
 function dispatch_kerns!(operators, branch_node, cumulator)

test/test_evaluation.jl

@@ -68,14 +68,14 @@ for turbo in [Val(false), Val(true)],
             true_y = realfnc.(X[1, :], X[2, :], X[3, :])
             !all(isfinite.(true_y)) && continue
 
-            @inferred eval_tree_array(tree, X, operators; turbo=turbo, bumper=Val(bumper))
+            @inferred eval_tree_array(tree, X, operators; turbo, bumper)
 
-            test_y = eval_tree_array(tree, X, operators; turbo=turbo, bumper=Val(bumper))[1]
+            test_y = eval_tree_array(tree, X, operators; turbo, bumper)[1]
 
             zero_tolerance = (T <: Union{Float16,Complex} ? 1e-4 : 1e-6)
             @test all(abs.(test_y .- true_y) / N .< zero_tolerance)
 
-            test_y_helper = tree(X, operators; turbo=turbo, bumper=Val(bumper))
+            test_y_helper = tree(X, operators; turbo, bumper)
             @test all(test_y .== test_y_helper)
         end
     end