Unit tests for resource management improved

Author: StyleT

dist/acl.js

@@ -303,6 +303,10 @@ angular.module('stylet.acl').service('AclService', ["AclRegistryService", functi
     this.addResource = function (resource, parent) {
         parent = typeof parent === 'undefined' ? null : parent;
 
+        if (typeof resource !== 'string' || resource === '') {
+            throw new Error('addResource() expects resource to be a not empty string');
+        }
+
         var resourceId = resource;
 
         if (self.hasResource(resourceId)) {

src/acl-service.js

@@ -302,6 +302,10 @@ angular.module('stylet.acl').service('AclService', function (AclRegistryService)
     this.addResource = function (resource, parent) {
         parent = typeof parent === 'undefined' ? null : parent;
 
+        if (typeof resource !== 'string' || resource === '') {
+            throw new Error('addResource() expects resource to be a not empty string');
+        }
+
         var resourceId = resource;
 
         if (self.hasResource(resourceId)) {

test/acl-service.js

@@ -190,10 +190,23 @@ describe('ncAclService', function () {
 
         it('should throw Exception during removal of unexisted resource', function () {
             expect(function() {
-                AclService.removeResource('unexisted');
+                AclService.removeResource('nonexistent');
             }).toThrow();
         });
 
+        it('ensures that an exception is thrown when a non-existent Resource is specified as a parent upon Resource addition', function () {
+            expect(function() {
+                AclService.addResource('Animal', 'nonexistent');
+            }).toThrowError();
+        });
+
+        it('ensures that the same Resource cannot be added more than once', function () {
+            AclService.addResource('tst');
+            expect(function() {
+                AclService.addResource('tst');
+            }).toThrowError();
+        });
+
         it('ensures that an exception is thrown when a non-existent resource is specified to each parameter of inherits()', function () {
             AclService.addResource('Animal');
 
@@ -206,6 +219,15 @@ describe('ncAclService', function () {
             }).toThrow();
         });
 
+        it('ensures that an exception is thrown when a not Resource is passed', function () {
+            expect(function() {
+                AclService.addResource({});
+            }).toThrowError(/expects resource to be/);
+            expect(function() {
+                AclService.addResource('');
+            }).toThrowError(/expects resource to be/);
+        });
+
         it('tests basic resource inheritance', function () {
             AclService
                 .addResource('city')