Unit tests improved

Author: StyleT

dist/acl.js

@@ -492,6 +492,10 @@ angular.module('stylet.acl').service('AclService', ["AclRegistryService", functi
     this.addRole = function (role, parents) {
         parents = typeof parents === 'undefined' ? null : parents;
 
+        if (typeof role !== 'string' || role === '') {
+            throw new Error('addRole() expects role to be a not empty string');
+        }
+
         _roleRegistry.add(role, parents);
 
         return self;

src/acl-service.js

@@ -491,6 +491,10 @@ angular.module('stylet.acl').service('AclService', function (AclRegistryService)
     this.addRole = function (role, parents) {
         parents = typeof parents === 'undefined' ? null : parents;
 
+        if (typeof role !== 'string' || role === '') {
+            throw new Error('addRole() expects role to be a not empty string');
+        }
+
         _roleRegistry.add(role, parents);
 
         return self;

test/acl-service.js

@@ -85,6 +85,15 @@ describe('ncAclService', function () {
 
     describe('Role management', function () {
 
+        it('ensures that basic addition and retrieval of a single Role works', function () {
+            expect(AclService.getRoles()).toEqual([]);
+
+            var role = AclService.addRole('guest').getRole('guest');
+
+            expect(role).toEqual('guest');
+            expect(AclService.getRole('guest')).toEqual('guest');
+        });
+
         it('ensures that getRoles() method works as expected', function () {
             expect(AclService.getRoles()).toEqual([]);
 
@@ -134,6 +143,21 @@ describe('ncAclService', function () {
             expect(AclService.isAllowed('Guest')).toBeFalsy();
         });
 
+        it('ensures that an exception is thrown when a non-existent Role is specified as a parent upon Role addition', function () {
+            expect(function() {
+                AclService.addRole('tst', 'unexisted');
+            }).toThrow();
+        });
+
+        it('ensures that an exception is thrown when a not Role is passed', function () {
+            expect(function() {
+                AclService.addRole({});
+            }).toThrowError(/expects role to be/);
+            expect(function() {
+                AclService.addRole('');
+            }).toThrowError(/expects role to be/);
+        });
+
     });
 
     describe('Resource management', function () {