refactor: revamp login and settings. migrate to overmind (#48)

* refactor: revamp settings and migrate to overmind

* feat: save token on login and reset session and settings on log out via overmind

* feat: upsert session on login

* refactor: get rid of redux user state, actions, reducer

* feat: saving the session after login. re-initialise the api client

* feat: wire up logout from overmind actions

* refactor: revamp effects. Revamp login, logout

* feat: redirect to the main window if already logged in

* fix: fix redirect link to app view main page

* feat: initializing overlay. Fix redirect route after login

* refactor: update process indicator

Author: Spring3

.eslintrc.json

@@ -21,7 +21,7 @@
     "ecmaVersion": 11,
     "sourceType": "module"
   },
-  "plugins": ["react"],
+  "plugins": ["react", "@emotion"],
   "rules": {
     "class-methods-use-this": "off",
     "comma-dangle": "off",

common/config.js

@@ -1,7 +1,5 @@
 const axios = require('axios');
 
-const storage = require('./storage');
-
 let instance;
 
 const TWENTY_SECONDS = 20000;
@@ -43,13 +41,6 @@ const getInstance = () => instance;
 
 const reset = () => { instance = undefined; };
 
-if (storage.user.isDefined()) {
-  const { api_key, redmineEndpoint } = storage.user.get();
-  if (api_key && redmineEndpoint) {
-    initialize(redmineEndpoint, api_key);
-  }
-}
-
 const handleReject = (error) => {
   // if this request was not cancelled
   if (!axios.isCancel(error)) {

common/request.js

@@ -5,7 +5,7 @@ const isDev = require('electron-is-dev');
 const { app, dialog, clipboard } = require('electron');
 const logger = require('electron-log');
 
-const { report } = require('../common/reporter');
+const { report } = require('./handlers/errorHandler');
 
 const config = {
   showDialog: !isDev,

common/storage.js

@@ -12,7 +12,7 @@ const electronUtils = require('electron-util');
 const isDev = require('electron-is-dev');
 const logger = require('electron-log');
 
-const storage = require('../common/storage');
+const storage = require('./storage');
 const { redmineClient } = require('./redmine');
 
 const Tray = require('./tray');
@@ -344,32 +344,53 @@ const initialize = () => {
     notification.show();
   });
 
-  ipcMain.on('menu', (event, { settings }) => {
+  ipcMain.on('menu', (event, message) => {
+    const { settings } = JSON.stringify(message);
     generateMenu({ settings });
   });
 
-  ipcMain.on('storage', (event, message) => {
-    const { action, data } = JSON.parse(message);
-    if (action === 'read') {
-      event.reply('storage', storage.settings.get());
-    } else if (action === 'save') {
-      storage.settings.set(data);
-    } else {
-      throw new Error('Unable to process the requested action', action);
-    }
-  });
+  storage.initializeSessionEvents(ipcMain);
 
   ipcMain.on('request', async (event, message) => {
-    const { payload, config, id } = JSON.parse(message);
-    console.log('Received a request for query', { payload, config });
+    const { payload, id } = JSON.parse(message);
+    console.log('Received a request for query', { payload });
+
     if (!redmineClient.isInitialized()) {
-      redmineClient.initialize(config);
+      const error = new Error('Unauthorized');
+      error.status = 401;
+      event.reply(`response:${id}`, { success: false, error });
+      return;
     }
 
     const response = await redmineClient.send(payload);
 
     event.reply(`response:${id}`, response);
   });
+
+  ipcMain.on('system-request', async (event, message) => {
+    const { action, payload, id } = JSON.parse(message);
+    console.log(`Received system request for ${action}`, { payload });
+
+    switch (action.toLowerCase()) {
+      case 'login': {
+        const response = await redmineClient.initialize({
+          endpoint: payload.endpoint,
+          token: payload.token,
+          headers: payload.headers
+        });
+        event.reply(`system-response:${id}`, response);
+        break;
+      }
+      case 'logout': {
+        redmineClient.reset();
+        await storage.resetActiveSession();
+        event.reply(`system-response:${id}`, { success: true });
+        break;
+      }
+      default:
+        break;
+    }
+  });
 };
 
 app.on('certificate-error', (event, webContents, _url, error, certificate, callback) => {
@@ -391,15 +412,8 @@ app.once('ready', () => {
   }
 
   // eslint-disable-next-line global-require
-  const config = require('../common/config');
+  const config = require('./env');
   PORT = config.PORT;
-  // eslint-disable-next-line global-require
-  require('../common/request'); // to initialize from storage
-
-  if (!storage.settings.isDefined()) {
-    // sets defaul value that storage.settings.get returns as a fallback
-    storage.settings.set(storage.settings.get());
-  }
 
   initialize();
   generateMenu();
@@ -410,6 +424,7 @@ app.once('ready', () => {
 
 app.on('window-all-closed', () => {
   if (process.platform !== 'darwin') {
+    storage.disposeSessionEvents(ipcMain);
     app.quit();
   }
 });

common/env.js renamed to main/env.js

@@ -1,26 +1,76 @@
 const got = require('got');
 const { transform } = require('./transformers/index');
 
-const createRequestClient = (initConfig = {}) => {
-  let isInitialized = false;
+const createRequestClient = () => {
   let instance;
-
-  const initialize = (config) => {
-    isInitialized = Boolean(config.endpoint && config.token);
-    instance = got.extend({
-      prefixUrl: config.endpoint,
-      headers: { 'X-Redmine-API-Key': config.token },
-      responseType: 'json'
-    });
-  };
+  let isInitialized;
 
   const handleUnsuccessfulRequest = (error) => ({
     success: false,
     error
   });
 
+  const initialize = async (data) => {
+    if (isInitialized) {
+      reset();
+    }
+
+    const route = 'users/current.json';
+
+    const configuration = data.token
+      ? {
+        prefixUrl: data.endpoint,
+        headers: { 'X-Redmine-API-Key': data.token },
+        responseType: 'json'
+      }
+      : {
+        prefixUrl: data.endpoint,
+        headers: {
+          Authorization: data.headers.Authorization
+        },
+        responseType: 'json'
+      };
+
+    try {
+      const response = await got(route, {
+        method: 'GET',
+        ...configuration
+      });
+
+      console.log(response.statusCode, response.body);
+
+      const loginSuccess = response.statusCode === 200;
+      isInitialized = loginSuccess;
+
+      if (loginSuccess) {
+        const payload = transform(route, response.body);
+
+        instance = got.extend({
+          ...configuration,
+          headers: {
+            'X-Redmine-API-Key': payload.token
+          }
+        });
+
+        return {
+          success: true,
+          payload
+        };
+      }
+
+      return handleUnsuccessfulRequest(response.body);
+    } catch (error) {
+      return handleUnsuccessfulRequest(error);
+    }
+  };
+
+  const reset = () => {
+    isInitialized = false;
+    instance = undefined;
+  };
+
   const send = async (data) => {
-    if (!instance && !data.headers?.Authorization) {
+    if (!isInitialized) {
       throw new Error('Http client is not initialized.');
     }
 
@@ -34,12 +84,8 @@ const createRequestClient = (initConfig = {}) => {
       console.log(response.statusCode, response.body);
 
       if (response.statusCode === 200) {
-        if (!isInitialized && data.route === 'users/current.json' && response.body.user?.api_key) {
-          initialize({ endpoint: initConfig.endpoint, token: response.body.user?.api_key });
-        }
-
         return {
-          data: transform(data.route, response.body),
+          payload: transform(data.route, response.body),
           success: true,
         };
       }
@@ -50,12 +96,11 @@ const createRequestClient = (initConfig = {}) => {
     }
   };
 
-  initialize(initConfig);
-
   return {
     initialize,
     isInitialized: () => isInitialized,
-    send
+    send,
+    reset
   };
 };