Send 404 when the resource or author is not found

[itaquito]

Hello!

Right now when you search for a resource/author that doesn't exist you get an interesting response:

{
  "id": null,
  "title": null,
  "tag": null,
  "current_version": null,
  "native_minecraft_version": null,
  "supported_minecraft_versions": null,
  "icon_link": "https://www.spigotmc.org/styles/default/xenresource/resource_icon.png",
  "author": {
    "id": null,
    "username": null
  },
  "premium": {
    "price": null,
    "currency": null
  },
  "stats": {
    "downloads": null,
    "updates": null,
    "reviews": {
      "unique": null,
      "total": null
    },
    "rating": null
  },
  "description": null
}

{
  "id": null,
  "username": null,
  "resource_count": null,
  "identities": {},
  "avatar": "https://www.spigotmc.org/styles/spigot/xenforo/avatars/avatar_male_l.png"
}

My suggestion is just adding a 404 error when this happens:

{"code":404,"message":"Resource not found."}

By doing this way, we (devs that use the API) can easily catch the error rather than checking if a value is null.

Also.... Thanks for this amazing tool.

[jacobsandersen]

Oh, wow. This is a regression. What routes does this happen on?

[jacobsandersen]

Reproduced on getAuthor and getResource but not findAuthor. Thank you I will submit a patch tomorrow.

[itaquito]

Oh! nvm, It is a bug! You were faster than me xP

Thanks again.

[itaquito]

I found a discrepancy in the 404 errors:
When you navigate thru the pages of getResourcesByAuthor, listResources or getResourceUpdates you will get an empty array when you get to the last page. However, when you go to a negative number page you will get {"code":404,"message":"Nothing was found for that request."}.

Shouldn't both responses be the same?

[jacobsandersen]

I found a discrepancy in the 404 errors:
When you navigate thru the pages of getResourcesByAuthor, listResources or getResourceUpdates you will get an empty array when you get to the last page. However, when you go to a negative number page you will get {"code":404,"message":"Nothing was found for that request."}.

Shouldn't both responses be the same?

Fair point, I'll address this as well tomorrow. Thank you

[jacobsandersen]

Took me one extra day - sorry. Had stuff going on yesterday.