removed unhittable code and removed a unit test for it. Updated code coverage filters in phpunit.xml to ignore test files because a utility function wasn't being used

Author: beardyman

lib/SparkPost/APIResource.php

@@ -48,7 +48,7 @@ public function __construct(SparkPost $sparkpost) {
    * @param string $mapKey a dot syntax path determining which value to set
    * @param mixed $value value for the given path
    */
-  protected function setMappedValue (&$model, $mapKey, $value) {
+  protected function setMappedValue(&$model, $mapKey, $value) {
     //get mapping
     if( empty(static::$parameterMappings) ) {
       // if parameterMappings is empty we can assume that no wrapper is defined
@@ -180,10 +180,6 @@ private function buildBody($options) {
   private function callResource( $action, $resourcePath=null, $options=[] ) {
     $action = strtoupper($action); // normalize
 
-    if( !in_array($action, ['POST', 'PUT', 'GET', 'DELETE'])) {
-      throw new \Exception('Invalid resource action');
-    }
-
     $url = $this->buildUrl($resourcePath, $options);
     $body = $this->buildBody($options);
 

lib/SparkPost/SparkPost.php

@@ -61,20 +61,13 @@ public function setupUnwrapped ($endpoint) {
 
   /**
    * @desc Merges passed in headers with default headers for http requests
-   * @return Array - headers to be set on http requests
    */
-  public function getHttpHeaders(Array $headers = null) {
+  public function getHttpHeaders() {
     $defaultOptions = [
       'Authorization' => $this->config['key'],
       'Content-Type' => 'application/json',
     ];
 
-    // Merge passed in headers with defaults
-    if (!is_null($headers)) {
-      foreach ($headers as $header => $value) {
-        $defaultOptions[$header] = $value;
-      }
-    }
     return $defaultOptions;
   }
 

phpunit.xml

@@ -32,6 +32,7 @@
   <filter>
         <blacklist>
               <directory>./vendor</directory>
+              <directory>./test</directory>
         </blacklist>
     </filter>
 </phpunit>

test/unit/SparkPostTest.php

@@ -66,11 +66,6 @@ public function testGetHeaders() {
     $this->assertEquals('application/json', $results['Content-Type']);
   }
 
-  public function testGetHeadersOverride() {
-    $results = $this->resource->getHttpHeaders(['Content-Type'=>'application/xml']);
-    $this->assertEquals('application/xml', $results['Content-Type']);
-  }
-
   public function testSetUnwrapped() {
     $results = $this->resource->setupUnwrapped('ASweetEndpoint');
     $this->assertEquals($this->resource->ASweetEndpoint, $results);