Correct assertion argument order in NotebookParsingDataTest

[sonarqube-agent]

This PR was automatically created by the Remediation Agent's Scheduled backlog remediation feature.

Why these issues? This test file issue was addressed as it represents a straightforward correction to assertion argument ordering that improves test output clarity. While test files are typically lower priority, this change follows standard testing conventions and requires minimal modification.

Fixed a SonarQube issue by swapping the arguments of an assertNotEquals call to follow the correct convention of (expected, actual). This ensures that assertion failure messages will be clear and meaningful, with the expected value appearing first as intended.

View Project in SonarCloud

---

Fixed Issues

java:S3415 - Swap these 2 arguments so they are in the correct order: expected value, actual value. • MAJOR • View issue

Location: python-commons/src/test/java/org/sonar/plugins/python/NotebookParsingDataTest.java:103

Why is this an issue?

The standard assertions library methods such as org.junit.Assert.assertEquals, and org.junit.Assert.assertSame expect the first argument to be the expected value and the second argument to be the actual value. For AssertJ instead, the argument of org.assertj.core.api.Assertions.assertThat is the actual value, and the subsequent calls contain the expected values.

What changed

This hunk swaps the arguments of assertNotEquals so that the hard-coded expected value ("test") comes first and the actual value (empty) comes second. The static analysis rule flags cases where the expected and actual arguments are in the wrong order in assertion methods, which would produce misleading error messages on test failure. By changing assertNotEquals(empty, "test") to assertNotEquals("test", empty), the arguments now follow the correct convention of (expected, actual). This also addresses the related flow indicating that the other argument needed to be swapped, as both arguments are now in their proper positions.

--- a/python-commons/src/test/java/org/sonar/plugins/python/NotebookParsingDataTest.java
+++ b/python-commons/src/test/java/org/sonar/plugins/python/NotebookParsingDataTest.java
@@ -103,1 +103,1 @@ class NotebookParsingDataTest {
-    assertNotEquals(empty, "test");
+    assertNotEquals("test", empty);

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.