refactor: replace getSpinner with getDefaultSpinner

Remove getSpinner() from constants/process to resolve circular dependency
between constants/process and spinner modules. All spinner instances now
use getDefaultSpinner() directly, which provides lazy loading without
circular import issues.

Changes:
- Remove getSpinner() and related imports from constants/process.ts
- Update debug.ts to use getDefaultSpinner() instead of getSpinner()
- Update spawn.ts to use getDefaultSpinner() instead of getSpinner()
- Update stdio/prompts.ts to use getDefaultSpinner() instead of getSpinner()
- Remove obsolete getSpinner tests from process.test.ts

Author: jdalton

src/constants/process.ts

@@ -2,9 +2,6 @@
  * Process control: abort signals and UI utilities.
  */
 
-import type { Spinner } from '../spinner'
-import { Spinner as SpinnerFn } from '../spinner'
-
 // Abort controller and signal.
 let _abortController: AbortController
 export function getAbortController(): AbortController {
@@ -17,12 +14,3 @@ export function getAbortController(): AbortController {
 export function getAbortSignal(): AbortSignal {
   return getAbortController().signal
 }
-
-// Spinner instance.
-let _spinner: Spinner | null | undefined
-export function getSpinner(): Spinner | null {
-  if (_spinner === undefined) {
-    _spinner = SpinnerFn() ?? null
-  }
-  return _spinner ?? null
-}

src/debug.ts

@@ -3,14 +3,14 @@
  * Provides Socket CLI specific debug functionality and logging formatters.
  */
 
-import { getSpinner } from './constants/process'
 import { getDebug } from './env/debug'
 import { getSocketDebug } from './env/socket'
 import isUnicodeSupported from './external/@socketregistry/is-unicode-supported'
 import debugJs from './external/debug'
 
 import { getDefaultLogger } from './logger'
 import { hasOwn } from './objects'
+import { getDefaultSpinner } from './spinner'
 import { applyLinePrefix } from './strings'
 
 // IMPORTANT: Do not use destructuring here - use direct assignment instead.
@@ -232,7 +232,7 @@ function debugDirNs(
       } as InspectOptions
     }
   }
-  const spinnerInstance = options.spinner || getSpinner()
+  const spinnerInstance = options.spinner || getDefaultSpinner()
   const wasSpinning = spinnerInstance?.isSpinning
   spinnerInstance?.stop()
   logger.info(`[DEBUG] ${callerName} ${pointingTriangle} object inspection:`)
@@ -269,7 +269,7 @@ function debugNs(namespacesOrOpts: NamespacesOrOptions, ...args: unknown[]) {
           ...args.slice(1),
         ]
       : args
-  const spinnerInstance = options.spinner || getSpinner()
+  const spinnerInstance = options.spinner || getDefaultSpinner()
   const wasSpinning = spinnerInstance?.isSpinning
   spinnerInstance?.stop()
   ReflectApply(logger.info, logger, logArgs)
@@ -307,7 +307,7 @@ function debugLogNs(namespacesOrOpts: NamespacesOrOptions, ...args: unknown[]) {
         ]
       : [`[DEBUG] ${callerName} ${pointingTriangle}`, ...args]
 
-  const spinnerInstance = options.spinner || getSpinner()
+  const spinnerInstance = options.spinner || getDefaultSpinner()
   const wasSpinning = spinnerInstance?.isSpinning
   spinnerInstance?.stop()
   ReflectApply(logger.info, logger, logArgs)
@@ -344,7 +344,7 @@ function debugCacheNs(
   const prefix = `[CACHE] ${callerName} ${pointingTriangle} ${operation}: ${key}`
   const logArgs = meta !== undefined ? [prefix, meta] : [prefix]
 
-  const spinnerInstance = options.spinner || getSpinner()
+  const spinnerInstance = options.spinner || getDefaultSpinner()
   const wasSpinning = spinnerInstance?.isSpinning
   spinnerInstance?.stop()
   ReflectApply(logger.info, logger, logArgs)

src/spawn.ts

@@ -26,7 +26,7 @@
  * - https://cheatsheetseries.owasp.org/cheatsheets/Nodejs_Security_Cheat_Sheet.html
  */
 
-import { getAbortSignal, getSpinner } from './constants/process'
+import { getAbortSignal } from './constants/process'
 
 import npmCliPromiseSpawn from './external/@npmcli/promise-spawn'
 import path from 'node:path'
@@ -35,10 +35,11 @@ import { isArray } from './arrays'
 import { whichSync } from './bin'
 import { isPath } from './paths/normalize'
 import { getOwn, hasOwn } from './objects'
+import { getDefaultSpinner } from './spinner'
 import { stripAnsi } from './strings'
 
 const abortSignal = getAbortSignal()
-const spinner = getSpinner()
+const spinner = getDefaultSpinner()
 
 // Define BufferEncoding type for TypeScript compatibility.
 type BufferEncoding = globalThis.BufferEncoding

src/stdio/prompts.ts

@@ -3,7 +3,7 @@
  * Provides inquirer.js integration with spinner support, context handling, and theming.
  */
 
-import { getAbortSignal, getSpinner } from '../constants/process'
+import { getAbortSignal } from '../constants/process'
 
 import checkboxRaw from '../external/@inquirer/checkbox'
 import confirmRaw from '../external/@inquirer/confirm'
@@ -14,13 +14,14 @@ import * as selectModuleImport from '../external/@inquirer/select'
 import yoctocolorsCjs from '../external/yoctocolors-cjs'
 
 import type { ColorValue } from '../colors'
+import { getDefaultSpinner } from '../spinner'
 import { getTheme } from '../themes/context'
 import { THEMES, type ThemeName } from '../themes/themes'
 import type { Theme } from '../themes/types'
 import { resolveColor } from '../themes/utils'
 
 const abortSignal = getAbortSignal()
-const spinner = getSpinner()
+const spinner = getDefaultSpinner()
 
 // Modules imported at the top - extract default and Separator
 const searchRaw = searchModule.default

test/unit/constants/process.test.ts

@@ -13,7 +13,6 @@ import { describe, expect, it } from 'vitest'
 import {
   getAbortController,
   getAbortSignal,
-  getSpinner,
 } from '@socketsecurity/lib/constants/process'
 
 describe('constants/process', () => {
@@ -74,30 +73,6 @@ describe('constants/process', () => {
     })
   })
 
-  describe('getSpinner', () => {
-    it('should return null or a Spinner object', () => {
-      const spinner = getSpinner()
-      expect(spinner === null || typeof spinner === 'object').toBe(true)
-    })
-
-    it('should return same instance on multiple calls (cached)', () => {
-      const first = getSpinner()
-      const second = getSpinner()
-      expect(first).toBe(second)
-    })
-
-    it('should handle spinner module not being available', () => {
-      // Should not throw even if spinner module is unavailable
-      expect(() => getSpinner()).not.toThrow()
-    })
-
-    it('should return null when spinner cannot be loaded', () => {
-      const spinner = getSpinner()
-      // In test environment, spinner might not be available
-      expect([null, 'object'].includes(typeof spinner)).toBe(true)
-    })
-  })
-
   describe('integration', () => {
     it('should allow AbortController and Signal to work together', () => {
       const controller = getAbortController()
@@ -137,14 +112,6 @@ describe('constants/process', () => {
       const allSame = signals.every(sig => sig === signals[0])
       expect(allSame).toBe(true)
     })
-
-    it('should cache spinner result', () => {
-      const first = getSpinner()
-      const second = getSpinner()
-      const third = getSpinner()
-      expect(first).toBe(second)
-      expect(second).toBe(third)
-    })
   })
 
   describe('error handling', () => {
@@ -155,10 +122,6 @@ describe('constants/process', () => {
     it('should not throw when getting AbortSignal', () => {
       expect(() => getAbortSignal()).not.toThrow()
     })
-
-    it('should gracefully handle spinner loading errors', () => {
-      expect(() => getSpinner()).not.toThrow()
-    })
   })
 
   describe('real-world usage', () => {