From 21f5e3e70be715259be01b07186d2d768676995f Mon Sep 17 00:00:00 2001 From: Harrison Carter Date: Thu, 24 Sep 2026 11:55:17 -0500 Subject: [PATCH 1/2] Check feature bits of ColorControl during profiling --- .../src/switch_utils/device_configuration.lua | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua b/drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua index 8e5f797877..00a46f1289 100644 --- a/drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua +++ b/drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua @@ -90,6 +90,16 @@ function SwitchDeviceConfiguration.assign_profile_for_onoff_ep(device, server_on or switch_utils.find_max_subset_device_type(ep_info, fields.DEVICE_TYPE_ID.SWITCH) or switch_utils.find_primary_device_type(ep_info) + -- some devices purporting to be COLOR_TEMPERATURE may actually expose EXTENDED_COLOR feature bits + if primary_dt_id == fields.DEVICE_TYPE_ID.LIGHT.COLOR_TEMPERATURE then + local color_control_ep = switch_utils.find_cluster_on_ep(ep_info, clusters.ColorControl.ID) or {} + local color_control_feature_map = color_control_ep.feature_map or 0 + if clusters.ColorControl.are_features_supported(clusters.ColorControl.types.Feature.XY, color_control_feature_map) or + clusters.ColorControl.are_features_supported(clusters.ColorControl.types.Feature.HUE_AND_SATURATION, color_control_feature_map) then + primary_dt_id = fields.DEVICE_TYPE_ID.LIGHT.EXTENDED_COLOR + end + end + local generic_profile = fields.device_type_profile_map[primary_dt_id] local static_electrical_tags = switch_utils.get_field_for_endpoint(device, fields.ELECTRICAL_TAGS, server_onoff_ep_id) From b150875dfc94d8bf2c91d2b3167363e860138ec7 Mon Sep 17 00:00:00 2001 From: Harrison Carter Date: Fri, 25 Sep 2026 10:50:03 -0500 Subject: [PATCH 2/2] Add fingerprint for 5187/256 device --- drivers/SmartThings/matter-switch/fingerprints.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/SmartThings/matter-switch/fingerprints.yml b/drivers/SmartThings/matter-switch/fingerprints.yml index fd2a35c321..ccb0e4fb32 100644 --- a/drivers/SmartThings/matter-switch/fingerprints.yml +++ b/drivers/SmartThings/matter-switch/fingerprints.yml @@ -577,6 +577,12 @@ matterManufacturer: vendorId: 0x1339 productId: 0x0055 deviceProfileName: plug-binary +#Goods iQ + - id: "5187/256" # Not WWST certified, exposes incorrect Device Type + deviceLabel: Cabinet Lights + vendorId: 0x1443 + productId: 0x0100 + deviceProfileName: light-color-level #Govee - id: "4999/24740" deviceLabel: Govee Square Ceiling Light (12 inch)