Skip to content

Commit 1b06bcc

Browse files
author
jantje
committed
the build no longer worked #1593
This has mostly to do with apache other plugins which now are somewhere else.
1 parent 41e6cc1 commit 1b06bcc

File tree

29 files changed

+318
-371
lines changed

29 files changed

+318
-371
lines changed

‎io.sloeber.core.nl1/META-INF/MANIFEST.MF‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: Sloeber core language pack
44
Bundle-SymbolicName: io.sloeber.core.nl1;singleton:=true
5-
Bundle-RequiredExecutionEnvironment: JavaSE-11
5+
Bundle-RequiredExecutionEnvironment: JavaSE-17
66
Bundle-Version: 4.4.1.qualifier
77
Fragment-Host: io.sloeber.core
88
Bundle-Vendor: Sloeber.io

‎io.sloeber.core/.classpath‎

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,24 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<classpath>
3-
<classpathentry kind="src" path="src"/>
4-
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11">
3+
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
54
<attributes>
6-
<attribute name="module" value="true"/>
5+
<attribute name="maven.pomderived" value="true"/>
76
</attributes>
87
</classpathentry>
9-
<classpathentry exported="true" kind="lib" path="lib/jssc-2.9.4.jar"/>
108
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
11-
<classpathentry kind="lib" path="lib/jsch-0.1.55.jar"/>
12-
<classpathentry kind="lib" path="lib/jmdns-3.5.7.jar"/>
9+
<classpathentry kind="src" output="bin" path="src">
10+
<attributes>
11+
<attribute name="optional" value="true"/>
12+
<attribute name="maven.pomderived" value="true"/>
13+
</attributes>
14+
</classpathentry>
15+
<classpathentry exported="true" kind="lib" path="lib/jsch-0.1.55.jar"/>
16+
<classpathentry exported="true" kind="lib" path="lib/jssc-2.9.4.jar"/>
17+
<classpathentry exported="true" kind="lib" path="lib/jmdns-3.5.7.jar"/>
18+
<classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER">
19+
<attributes>
20+
<attribute name="maven.pomderived" value="true"/>
21+
</attributes>
22+
</classpathentry>
1323
<classpathentry kind="output" path="bin"/>
1424
</classpath>

‎io.sloeber.core/.gitignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
/bin/
22
/target/
3+
.settings/*

‎io.sloeber.core/.settings/org.eclipse.jdt.core.prefs‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎io.sloeber.core/META-INF/MANIFEST.MF‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
33
Bundle-Name: Arduino eclipse plugin
44
Bundle-SymbolicName: io.sloeber.core;singleton:=true
55
Bundle-Version: 4.4.1.qualifier
6-
Bundle-RequiredExecutionEnvironment: JavaSE-11
6+
Bundle-RequiredExecutionEnvironment: JavaSE-17
77
Bundle-Vendor: Sloeber.io
88
Bundle-ActivationPolicy: lazy
99
Bundle-Activator: io.sloeber.core.Activator
@@ -13,17 +13,16 @@ Bundle-ClassPath: .,
1313
lib/jmdns-3.5.7.jar
1414
Require-Bundle: org.eclipse.cdt.managedbuilder.core,
1515
org.eclipse.core.filesystem,
16-
org.eclipse.cdt.core;bundle-version="7.0.0",
17-
org.apache.commons.compress,
18-
org.apache.commons.lang,
16+
org.eclipse.cdt.core,
1917
com.google.gson,
2018
org.eclipse.equinox.security,
2119
org.eclipse.core.runtime,
22-
org.apache.commons.io;bundle-version="2.0.0",
23-
org.eclipse.ui;bundle-version="3.117.0",
20+
org.eclipse.ui,
2421
org.eclipse.ui.console,
2522
org.eclipse.debug.core,
26-
org.eclipse.core.variables
23+
org.eclipse.core.variables,
24+
org.apache.commons.io,
25+
org.apache.commons.compress
2726
Export-Package: cc.arduino.packages;x-internal:=true,
2827
cc.arduino.packages.discoverers;x-internal:=true,
2928
cc.arduino.packages.ssh;x-internal:=true,

‎io.sloeber.core/src/io/sloeber/core/Activator.java‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package io.sloeber.core;
22

3+
import static io.sloeber.core.common.Common.*;
34
import static io.sloeber.core.common.Const.*;
45
import static org.eclipse.core.resources.IResource.*;
56

@@ -10,8 +11,6 @@
1011
import java.net.MalformedURLException;
1112
import java.net.URL;
1213

13-
import org.apache.commons.io.FileUtils;
14-
import org.apache.commons.lang.SystemUtils;
1514
import org.eclipse.cdt.core.CCorePlugin;
1615
import org.eclipse.cdt.core.model.CoreModel;
1716
import org.eclipse.cdt.core.settings.model.CProjectDescriptionEvent;
@@ -402,13 +401,13 @@ private static void installOtherStuff() {
402401
String AWK_URL = "https://github.com/Sloeber/arduino-eclipse-plugin/files/7102568/awk_GNU_64_bit_V4_2_1.zip";
403402

404403
// On Windows install make and awk
405-
if (SystemUtils.IS_OS_WINDOWS) {
404+
if (isWindows) {
406405
// Install make if needed
407406
IPath localMakePath = ConfigurationPreferences.getMakePath();
408407
if (localMakePath.append(MAKE_EXE).toFile().exists()) {
409408
if (!localMakePath.append(SH_EXE).toFile().exists()) {
410409
try {
411-
FileUtils.deleteDirectory(new File(localMakePath.toString()));
410+
deleteDirectory(localMakePath);
412411
} catch (IOException e) {
413412
// should not happen
414413
e.printStackTrace();

‎io.sloeber.core/src/io/sloeber/core/api/CodeDescription.java‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
import java.util.ArrayList;
1010
import java.util.Map;
1111
import java.util.TreeMap;
12+
import java.util.stream.Collectors;
1213

1314
import org.apache.commons.io.FileUtils;
14-
import org.apache.commons.lang.StringUtils;
1515
import org.eclipse.core.resources.IProject;
1616
import org.eclipse.core.runtime.CoreException;
1717
import org.eclipse.core.runtime.IPath;
@@ -205,6 +205,7 @@ Map<String, IPath> createFiles(IProject project, IProgressMonitor monitor) throw
205205
if (myMakeLinks) {
206206
Helpers.linkDirectory(project, curPath, new Path("/")); //$NON-NLS-1$
207207
} else {
208+
// Files.copy(curPath.toPath(), project.getLocation().toPath());
208209
FileUtils.copyDirectory(curPath.toFile(), project.getLocation().toFile());
209210
FileModifiers.addPragmaOnce(curPath);
210211
}
@@ -237,7 +238,7 @@ public ArrayList<IPath> getExamples() {
237238

238239
private void saveLastUsedExamples() {
239240
if (myExamples != null) {
240-
String toStore = StringUtils.join(myExamples, "\n"); //$NON-NLS-1$
241+
String toStore = myExamples.stream().map(Object::toString).collect(Collectors.joining("\n")); //$NON-NLS-1$
241242
InstancePreferences.setGlobalValue(KEY_LAST_USED_EXAMPLES, toStore);
242243
} else {
243244
InstancePreferences.setGlobalValue(KEY_LAST_USED_EXAMPLES, new String());

‎io.sloeber.core/src/io/sloeber/core/api/Defaults.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package io.sloeber.core.api;
22

3+
import static io.sloeber.core.common.Common.*;
34
import static io.sloeber.core.common.Const.*;
45

5-
import org.apache.commons.lang.SystemUtils;
66
import org.eclipse.core.runtime.IPath;
77
import org.eclipse.core.runtime.Path;
88

@@ -32,15 +32,15 @@ public class Defaults {
3232
*/
3333
public static String getPrivateLibraryPath() {
3434
IPath homPath = new Path(System.getProperty("user.home"));
35-
if (SystemUtils.IS_OS_MAC || SystemUtils.IS_OS_WINDOWS) {
35+
if (isMac || isWindows) {
3636
homPath = homPath.append("Documents");
3737
}
3838
return homPath.append("Arduino").append(LIBRARY_PATH_SUFFIX).toString();
3939
}
4040

4141
public static String getPrivateHardwarePath() {
4242
IPath homPath = new Path(System.getProperty("user.home"));
43-
if (SystemUtils.IS_OS_MAC || SystemUtils.IS_OS_WINDOWS) {
43+
if (isMac || isWindows) {
4444
homPath = homPath.append("Documents");
4545
}
4646
return homPath.append("Arduino").append(ARDUINO_HARDWARE_FOLDER_NAME).toString();

‎io.sloeber.core/src/io/sloeber/core/api/LaunchConfiguration.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.sloeber.core.api;
22

3-
import org.apache.commons.lang.StringUtils;
43
import org.eclipse.core.resources.IProject;
54
import org.eclipse.core.resources.ResourcesPlugin;
65
import org.eclipse.core.runtime.CoreException;
@@ -82,7 +81,7 @@ private void loadSettingsFromConfiguration() {
8281
* @return the project handle if a project was found
8382
*/
8483
public static IProject findProject(String name) {
85-
if (StringUtils.isNotBlank(name) && new Path(name).isValidPath(name)) {
84+
if ((!name.isBlank()) && new Path(name).isValidPath(name)) {
8685
IProject p = ResourcesPlugin.getWorkspace().getRoot().getProject(name);
8786
if (p.getLocation() != null)
8887
return p;

‎io.sloeber.core/src/io/sloeber/core/common/Common.java‎

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,14 @@
33
import static io.sloeber.core.common.Const.*;
44

55
import java.io.File;
6+
import java.io.IOException;
67
import java.net.URI;
78
import java.net.URISyntaxException;
89
import java.net.URL;
10+
import java.nio.file.Files;
11+
import java.nio.file.Path;
912
import java.nio.file.Paths;
13+
import java.util.Comparator;
1014

1115
import org.eclipse.cdt.core.CCorePlugin;
1216
import org.eclipse.cdt.core.envvar.IEnvironmentVariableManager;
@@ -18,7 +22,6 @@
1822
import org.eclipse.core.resources.ResourcesPlugin;
1923
import org.eclipse.core.runtime.IPath;
2024
import org.eclipse.core.runtime.IStatus;
21-
import org.eclipse.core.runtime.Path;
2225
import org.eclipse.core.runtime.Platform;
2326
import org.eclipse.core.runtime.Status;
2427
import org.eclipse.ui.statushandlers.StatusManager;
@@ -28,7 +31,7 @@
2831
public class Common {
2932

3033
public final static String sloeberHome = getSloeberHome();
31-
public final static IPath sloeberHomePath = new Path(sloeberHome);
34+
public final static IPath sloeberHomePath = new org.eclipse.core.runtime.Path(sloeberHome);
3235
public final static String sloeberHomePathToString = sloeberHomePath.toString();
3336

3437
private static String getSloeberHome() {
@@ -239,7 +242,7 @@ public static String makePathEnvironmentString(IPath path) {
239242
}
240243

241244
public static String makePathVersionString(File file) {
242-
return new Path(file.getPath()).toString().replace(sloeberHomePathToString, SLOEBER_HOME_VAR);
245+
return file.getPath().replace(sloeberHomePathToString, SLOEBER_HOME_VAR);
243246
}
244247

245248
/**
@@ -278,4 +281,21 @@ static public String getOldWayEnvVar(ICConfigurationDescription confDesc, String
278281
getBuildEnvironmentVariable(confDesc, envName.toUpperCase(), EMPTY, false), false);
279282
}
280283

284+
public static void deleteDirectory(org.eclipse.core.runtime.IPath directory) throws IOException {
285+
deleteDirectory(Path.of(directory.toOSString()));
286+
}
287+
288+
public static void deleteDirectory(Path directory) throws IOException {
289+
Files.walk(directory).sorted(Comparator.reverseOrder()).map(Path::toFile).forEach(File::delete);
290+
}
291+
292+
/**
293+
* this is some code to work around issue
294+
* https://github.com/eclipse-cdt/cdt/issues/539
295+
*
296+
*/
297+
public static String getFileExtension(String fileName) {
298+
int dotPosition = fileName.lastIndexOf('.');
299+
return (dotPosition == -1 || dotPosition == fileName.length() - 1) ? "" : fileName.substring(dotPosition + 1); //$NON-NLS-1$
300+
}
281301
}

0 commit comments

Comments
 (0)