Store represented_value in the result objects

Author: amomchilov

lib/graphql/execution/interpreter/runtime.rb

@@ -10,18 +10,23 @@ class Interpreter
       class Runtime
 
         module GraphQLResult
-          def initialize(result_name, parent_result)
+          # FIXME: storing `represented_value` here holds onto a lot of objects, keeping them from GCing and increasing peak memory.
+          #   ... but the value is only needed for lists with skippable items.
+          #   Maybe we can set to `nil` unless we know this object is a skippable list item
+          #   (i.e. a direct child of a list with `skip_items_on_raise: true`)
+          def initialize(result_name, parent_result, represented_value)
             @graphql_parent = parent_result
             if parent_result && parent_result.graphql_dead
               @graphql_dead = true
             end
             @graphql_result_name = result_name
             # Jump through some hoops to avoid creating this duplicate storage if at all possible.
             @graphql_metadata = nil
+            @represented_value = represented_value
           end
 
           attr_accessor :graphql_dead
-          attr_reader :graphql_parent, :graphql_result_name
+          attr_reader :graphql_parent, :graphql_result_name, :represented_value
 
           # Although these are used by only one of the Result classes,
           # it's handy to have the methods implemented on both (even though they just return `nil`)
@@ -48,7 +53,7 @@ def can_be_skipped?
         end
 
         class GraphQLResultHash
-          def initialize(_result_name, _parent_result)
+          def initialize(_result_name, _parent_result, _represented_value)
             super
             @graphql_result_data = {}
           end
@@ -109,7 +114,7 @@ def [](k)
         class GraphQLResultArray
           include GraphQLResult
 
-          def initialize(_result_name, _parent_result)
+          def initialize(_result_name, _parent_result, _represented_value)
             super
             @graphql_result_data = []
           end
@@ -177,7 +182,7 @@ def initialize(query:)
           @multiplex_context = query.multiplex.context
           # Start this off empty:
           Thread.current[:__graphql_runtime_info] = nil
-          @response = GraphQLResultHash.new(nil, nil)
+          @response = GraphQLResultHash.new(nil, nil, query.root_value)
           # Identify runtime directives by checking which of this schema's directives have overridden `def self.resolve`
           @runtime_directive_names = []
           noop_resolve_owner = GraphQL::Schema::Directive.singleton_class
@@ -240,7 +245,7 @@ def run_eager
               # directly evaluated and the results can be written right into the main response hash.
               tap_or_each(gathered_selections) do |selections, is_selection_array|
                 if is_selection_array
-                  selection_response = GraphQLResultHash.new(nil, nil)
+                  selection_response = GraphQLResultHash.new(nil, nil, query.root_value)
                   final_response = @response
                 else
                   selection_response = @response
@@ -773,7 +778,7 @@ def continue_field(path, value, owner_type, field, current_type, ast_node, next_
             after_lazy(object_proxy, owner: current_type, path: path, ast_node: ast_node, field: field, owner_object: owner_object, arguments: arguments, trace: false, result_name: result_name, result: selection_result) do |inner_object|
               continue_value = continue_value(path, inner_object, owner_type, field, is_non_null, ast_node, result_name, selection_result)
               if HALT != continue_value
-                response_hash = GraphQLResultHash.new(result_name, selection_result)
+                response_hash = GraphQLResultHash.new(result_name, selection_result, continue_value)
                 set_result(selection_result, result_name, response_hash)
                 gathered_selections = gather_selections(continue_value, current_type, next_selections)
                 # There are two possibilities for `gathered_selections`:
@@ -786,7 +791,7 @@ def continue_field(path, value, owner_type, field, current_type, ast_node, next_
                 #    (Technically, it's possible that one of those entries _doesn't_ require isolation.)
                 tap_or_each(gathered_selections) do |selections, is_selection_array|
                   if is_selection_array
-                    this_result = GraphQLResultHash.new(result_name, selection_result)
+                    this_result = GraphQLResultHash.new(result_name, selection_result, continue_value)
                     final_result = response_hash
                   else
                     this_result = response_hash
@@ -813,7 +818,7 @@ def continue_field(path, value, owner_type, field, current_type, ast_node, next_
             inner_type = current_type.of_type
             # This is true for objects, unions, and interfaces
             use_dataloader_job = !inner_type.unwrap.kind.input?
-            response_list = GraphQLResultArray.new(result_name, selection_result)
+            response_list = GraphQLResultArray.new(result_name, selection_result, value)
             response_list.graphql_non_null_list_items = inner_type.non_null?
             response_list.graphql_skip_list_items_that_raise = current_type.skip_nodes_on_raise?
             set_result(selection_result, result_name, response_list)