Added class constant visibility as cli option

Author: MaximilianKresse

README.md

@@ -6,7 +6,7 @@ completion for your IDE when encrypting your library with e.g.
 [the ioncube encoder](http://www.ioncube.com/php_encoder.php).
 
 [![Build Status](https://travis-ci.org/Setasign/php-stub-generator.svg?branch=master)](https://travis-ci.org/Setasign/php-stub-generator)
-[![Minimum PHP Version](http://img.shields.io/badge/php-%3E%3D%207.1-8892BF.svg)](https://php.net/)
+[![Minimum PHP Version](http://img.shields.io/badge/php-%3E%3D%207.2-8892BF.svg)](https://php.net/)
 [![License](https://img.shields.io/packagist/l/setasign/php-stub-generator.svg)](https://packagist.org/packages/setasign/php-stub-generator)
 
 ## Installation
@@ -44,7 +44,39 @@ file_put_contents(__DIR__ . '/setapdf-core-stub.php', $output);
 Alternatively you could just call the cli helper.
 
 ```bash
-vendor/bin/php-stub-generator generate vendor/setasign/setapdf-core/library setapdf-core-stub.php
+vendor/bin/php-stub-generator generate setapdf-core/library setapdf-core-stub.php
+```
+
+## Settings
+The PhpStubGenerator class has following settings:
+```php
+class PhpStubGenerator
+{
+    /**
+     * End of line character(s).
+     *
+     * Doesn't change the used EOL character(s) of doc blocks.
+     *
+     * @var string
+     */
+    public static $eol = "\n";
+
+    /**
+     * Tab character(s)
+     *
+     * @var string
+     */
+    public static $tab = '    ';
+
+    /**
+     * If enabled all generated class constants get a visibility (the generated stubs require PHP >= 7.1)
+     * 
+     * Within the cli tool can be set with the option "--addClassConstantsVisibility"
+     * 
+     * @var bool
+     */
+    public static $addClassConstantsVisibility = false;
+}
 ```
 
 ## Drawbacks / TODOs
@@ -53,4 +85,3 @@ vendor/bin/php-stub-generator generate vendor/setasign/setapdf-core/library seta
   Additionally the "declaring class" of imported trait methods is the importing class and not like expected the trait.
 - Calculated constants or constants that use other constants like \_\_DIR\_\_ will be filled with the values of the 
   runtime environment.
-- At the moment we only support public class constants due to missing support of ReflectionClassConstant in [goaop/parser-reflection](https://github.com/goaop/parser-reflection).

bin/php-stub-generator

@@ -10,11 +10,11 @@ use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
-if (version_compare('7.1.0', PHP_VERSION, '>=')) {
+if (version_compare('7.2', PHP_VERSION, '>=')) {
     fwrite(
         STDERR,
         sprintf(
-            'This version of php-stub-generator is supported on PHP 7.1.' . PHP_EOL .
+            'This version of php-stub-generator is supported on PHP 7.2.' . PHP_EOL .
             'You are using PHP %s (%s).' . PHP_EOL,
             PHP_VERSION,
             PHP_BINARY
@@ -69,18 +69,29 @@ require PHP_STUB_GENERATOR_COMPOSER_INSTALL;
         InputOption::VALUE_IS_ARRAY | InputOption::VALUE_REQUIRED,
         'Exclude any directories'
     )
+    ->addOption(
+        'addClassConstantsVisibility',
+        false,
+        InputOption::VALUE_NONE,
+        'If enabled all generated class constants get a visibility (the generated stubs require PHP >= 7.1)'
+    )
     ->setCode(function (
         InputInterface $input,
         OutputInterface $output
     ) {
         $sourceDirectory = $input->getArgument('source');
         $outputPath = $input->getArgument('output');
         $excludes = $input->getOption('exclude');
+        $addClassConstantsVisibility = $input->getOption('addClassConstantsVisibility');
 
         if (!is_dir($sourceDirectory)) {
             throw new \InvalidArgumentException('Invalid source directory!');
         }
 
+        if ($addClassConstantsVisibility) {
+            PhpStubGenerator::$addClassConstantsVisibility = true;
+        }
+
         $generator = new PhpStubGenerator();
         $generator->addSource(
             'setapdf-core',

src/PhpStubGenerator.php

@@ -14,16 +14,26 @@
 class PhpStubGenerator
 {
     /**
+     * End of line character(s).
+     *
+     * Doesn't change the used EOL character(s) of doc blocks.
+     *
      * @var string
      */
     public static $eol = "\n";
 
     /**
+     * Tab character(s)
+     *
      * @var string
      */
     public static $tab = '    ';
 
     /**
+     * If enabled all generated class constants get a visibility (the generated stubs require PHP >= 7.1).
+     *
+     * Within the cli tool can be set with the option "--addClassConstantsVisibility"
+     *
      * @var bool
      */
     public static $addClassConstantsVisibility = false;