Have Env.StrictMode on array with missing comma

Author: mythz

src/ServiceStack.Text/Json/JsonTypeSerializer.cs

@@ -718,6 +718,8 @@ public bool EatItemSeperatorOrMapEndChar(ReadOnlySpan<char> value, ref int i)
 
                 for (; i < value.Length; i++) { var c = value[i]; if (!JsonUtils.IsWhiteSpace(c)) break; } //Whitespace inline
             }
+            else if (Env.StrictMode) throw new Exception(
+                $"Expected '{JsWriter.ItemSeperator}' or '{JsWriter.MapEndChar}'");
 
             return success;
         }

src/ServiceStack.Text/Jsv/JsvTypeSerializer.cs

@@ -379,7 +379,12 @@ public bool EatItemSeperatorOrMapEndChar(string value, ref int i)
 
             var success = value[i] == JsWriter.ItemSeperator
                 || value[i] == JsWriter.MapEndChar;
-            i++;
+
+            if (success)
+                i++;
+            else if (Env.StrictMode) throw new Exception(
+                $"Expected '{JsWriter.ItemSeperator}' or '{JsWriter.MapEndChar}'");
+            
             return success;
         }
 
@@ -391,9 +396,9 @@ public bool EatItemSeperatorOrMapEndChar(ReadOnlySpan<char> value, ref int i)
                 || value[i] == JsWriter.MapEndChar;
 
             if (success)
-            {
                 i++;
-            }
+            else if (Env.StrictMode) throw new Exception(
+                $"Expected '{JsWriter.ItemSeperator}' or '{JsWriter.MapEndChar}'");
 
             return success;
         }
@@ -411,7 +416,7 @@ public ReadOnlySpan<char> EatValue(ReadOnlySpan<char> value, ref int i)
         {
             var tokenStartPos = i;
             var valueLength = value.Length;
-            if (i == valueLength) return default(ReadOnlySpan<char>);
+            if (i == valueLength) return default;
 
             var valueChar = value[i];
             var withinQuotes = false;
@@ -422,7 +427,7 @@ public ReadOnlySpan<char> EatValue(ReadOnlySpan<char> value, ref int i)
                 //If we are at the end, return.
                 case JsWriter.ItemSeperator:
                 case JsWriter.MapEndChar:
-                    return default(ReadOnlySpan<char>);
+                    return default;
 
                 //Is Within Quotes, i.e. "..."
                 case JsWriter.QuoteChar:

tests/ServiceStack.Text.Tests/JsonTests/OnDeserializationErrorTests.cs

@@ -57,11 +57,14 @@ public void TestReset()
         }
 
         [Test]
-        public void Invokes_callback_deserialization_of_array_with_missing_comma()
+        public void StrictMode_throws_Exception_on_array_with_missing_comma()
         {
+            Env.StrictMode = true;
             string json = @"{""Values"": [ { ""Val"": ""a""} { ""Val"": ""b""}] }";
+            
+            Assert.Throws<SerializationException>(() => json.FromJson<TestDtoWithArray>());
 
-            AssertThatInvalidJsonInvokesExpectedCallback<TestDtoWithArray>(json, "Values", @"[ { ""Val"": ""a""} { ""Val"": ""b""}]", typeof(TestChildDto[]), null);
+            Env.StrictMode = false;
         }
 
         [Test]