Fix in InsertOnly for param greater than default length (#654)

* Fix in InsertOnly for param greater than default length

* Fixes related to InsertOnly in Async and Legacy versions

Author: OlegNadymov

src/ServiceStack.OrmLite.Firebird/FirebirdOrmLiteDialectProvider.cs

@@ -161,8 +161,7 @@ public override string ToInsertRowStatement(IDbCommand cmd, object objWithProper
                     sbColumnNames.Append(GetQuotedColumnName(fieldDef.FieldName));
                     sbColumnValues.Append(this.GetParam(SanitizeFieldNameForParamName(fieldDef.FieldName)));
 
-                    var p = AddParameter(cmd, fieldDef);
-                    p.Value = GetFieldValue(fieldDef, fieldDef.GetValue(objWithProperties)) ?? DBNull.Value;
+                    AddParameter(cmd, fieldDef);
                 }
                 catch (Exception ex)
                 {

src/ServiceStack.OrmLite.SqlServer/SqlServerOrmLiteDialectProvider.cs

@@ -361,8 +361,7 @@ public override string ToInsertRowStatement(IDbCommand cmd, object objWithProper
                     sbColumnNames.Append(GetQuotedColumnName(fieldDef.FieldName));
                     sbColumnValues.Append(this.GetParam(SanitizeFieldNameForParamName(fieldDef.FieldName)));
 
-                    var p = AddParameter(cmd, fieldDef);
-                    p.Value = GetFieldValue(fieldDef, fieldDef.GetValue(objWithProperties)) ?? DBNull.Value;
+                    AddParameter(cmd, fieldDef);
                 }
                 catch (Exception ex)
                 {

src/ServiceStack.OrmLite/Async/WriteExpressionCommandExtensionsAsync.cs

@@ -190,7 +190,11 @@ internal static Task InsertOnlyAsync<T>(this IDbCommand dbCmd, T obj, string[] o
 
             OrmLiteConfig.InsertFilter?.Invoke(dbCmd, obj);
 
-            var sql = dbCmd.GetDialectProvider().ToInsertRowStatement(dbCmd, obj, onlyFields);
+            var dialectProvider = dbCmd.GetDialectProvider();
+            var sql = dialectProvider.ToInsertRowStatement(dbCmd, obj, onlyFields);
+
+            dialectProvider.SetParameterValues<T>(dbCmd, obj);
+
             return dbCmd.ExecuteSqlAsync(sql, token);
         }
 

src/ServiceStack.OrmLite/Expressions/WriteExpressionCommandExtensions.cs

@@ -339,6 +339,8 @@ public static long InsertOnly<T>(this IDbCommand dbCmd, T obj, string[] onlyFiel
             var dialectProvider = dbCmd.GetDialectProvider();
             var sql = dialectProvider.ToInsertRowStatement(dbCmd, obj, onlyFields);
 
+            dialectProvider.SetParameterValues<T>(dbCmd, obj);
+
             if (selectIdentity)
                 return dbCmd.ExecLongScalar(sql + dialectProvider.GetLastInsertIdSqlSuffix<T>());
 

src/ServiceStack.OrmLite/Legacy/WriteExpressionCommandExtensionsAsyncLegacy.cs

@@ -55,7 +55,11 @@ internal static Task InsertOnlyAsync<T>(this IDbCommand dbCmd, T obj, SqlExpress
             if (OrmLiteConfig.InsertFilter != null)
                 OrmLiteConfig.InsertFilter(dbCmd, obj);
 
-            var sql = dbCmd.GetDialectProvider().ToInsertRowStatement(dbCmd, obj, onlyFields.InsertFields);
+            var dialectProvider = dbCmd.GetDialectProvider();
+            var sql = dialectProvider.ToInsertRowStatement(dbCmd, obj, onlyFields.InsertFields);
+
+            dialectProvider.SetParameterValues<T>(dbCmd, obj);
+            
             return dbCmd.ExecuteSqlAsync(sql, token);
         }
     }

src/ServiceStack.OrmLite/Legacy/WriteExpressionCommandExtensionsLegacy.cs

@@ -97,7 +97,11 @@ public static void InsertOnly<T>(this IDbCommand dbCmd, T obj, SqlExpression<T>
             if (OrmLiteConfig.InsertFilter != null)
                 OrmLiteConfig.InsertFilter(dbCmd, obj);
 
-            var sql = dbCmd.GetDialectProvider().ToInsertRowStatement(dbCmd, obj, onlyFields.InsertFields);
+            var dialectProvider = dbCmd.GetDialectProvider();
+            var sql = dialectProvider.ToInsertRowStatement(dbCmd, obj, onlyFields.InsertFields);
+            
+            dialectProvider.SetParameterValues<T>(dbCmd, obj);
+
             dbCmd.ExecuteSql(sql);
         }
     }

src/ServiceStack.OrmLite/OrmLiteDialectProviderBase.cs

@@ -623,8 +623,7 @@ public virtual string ToInsertRowStatement(IDbCommand cmd, object objWithPropert
                     sbColumnNames.Append(GetQuotedColumnName(fieldDef.FieldName));
                     sbColumnValues.Append(this.GetParam(SanitizeFieldNameForParamName(fieldDef.FieldName)));
 
-                    var p = AddParameter(cmd, fieldDef);
-                    p.Value = GetFieldValue(fieldDef, fieldDef.GetValue(objWithProperties)) ?? DBNull.Value;
+                    AddParameter(cmd, fieldDef);
                 }
                 catch (Exception ex)
                 {

tests/ServiceStack.OrmLite.SqlServer.Tests/Issues/StringLengthParamTests.cs

@@ -40,5 +40,30 @@ public void Can_select_param_greater_than_default_length()
 
             OrmLiteConfig.DialectProvider.GetStringConverter().UseUnicode = hold;
         }
+
+        [Test]
+        public void Can_insert_only_param_greater_than_default_length()
+        {
+            var hold = OrmLiteConfig.DialectProvider.GetStringConverter().UseUnicode;
+            OrmLiteConfig.DialectProvider.GetStringConverter().UseUnicode = true;
+
+            using (var db = OpenDbConnection())
+            {
+                db.DropAndCreateTable<StringLengthParamTest>();
+
+                var name = "a" + new string('b', 8000) + "c";
+
+                db.InsertOnly(new StringLengthParamTest
+                {
+                    Name = name
+                }, s => s.Name);
+
+                var people = db.Select<StringLengthParamTest>(p => p.Name == name);
+
+                Assert.That(people.Count, Is.EqualTo(1));
+            }
+
+            OrmLiteConfig.DialectProvider.GetStringConverter().UseUnicode = hold;
+        }
     }
 }