Extract SetParameterSize method (#655)

* Create parameter with DBNull.Value for null values in OrmLiteReadCommandExtensions (#635)

* Create parameter with DBNull.Value for null values in OrmLiteReadCommandExtensions (#635) (#30)

* UnsafeGroupBy

* Extract SetParameterSize method

* Remove generic argument in SetParameterValue method

Author: OlegNadymov

src/ServiceStack.OrmLite.PostgreSQL/PostgreSQLDialectProvider.cs

@@ -695,15 +695,15 @@ public override void SetParameter(FieldDefinition fieldDef, IDbDataParameter p)
 
         public virtual bool UseRawValue(string columnDef) => columnDef?.EndsWith("[]") == true;
 
-        protected override object GetValue<T>(FieldDefinition fieldDef, object obj)
+        protected override object GetValue(FieldDefinition fieldDef, object obj)
         {
             if (fieldDef.CustomFieldDefinition != null && NativeTypes.ContainsKey(fieldDef.CustomFieldDefinition)
                 && UseRawValue(fieldDef.CustomFieldDefinition))
             {
                 return fieldDef.GetValue(obj);
             }
 
-            return base.GetValue<T>(fieldDef, obj);
+            return base.GetValue(fieldDef, obj);
         }
 
         public override void PrepareStoredProcedureStatement<T>(IDbCommand cmd, T obj)

src/ServiceStack.OrmLite/OrmLiteDialectProviderBase.cs

@@ -977,7 +977,7 @@ public virtual void SetParameterValues<T>(IDbCommand dbCmd, object obj)
                     continue;
                 }
 
-                SetParameterValue<T>(fieldDef, p, obj);
+                SetParameterValue(fieldDef, p, obj);
             }
         }
 
@@ -986,19 +986,24 @@ public Dictionary<string, FieldDefinition> GetFieldDefinitionMap(ModelDefinition
             return modelDef.GetFieldDefinitionMap(SanitizeFieldNameForParamName);
         }
 
-        public virtual void SetParameterValue<T>(FieldDefinition fieldDef, IDataParameter p, object obj)
+        public virtual void SetParameterValue(FieldDefinition fieldDef, IDataParameter p, object obj)
         {
-            var value = GetValueOrDbNull<T>(fieldDef, obj);
+            var value = GetValueOrDbNull(fieldDef, obj);
             p.Value = value;
 
+            SetParameterSize(fieldDef, p);
+        }
+
+        protected virtual void SetParameterSize(FieldDefinition fieldDef, IDataParameter p)
+        {
             if (p.Value is string s && p is IDbDataParameter dataParam && dataParam.Size > 0 && s.Length > dataParam.Size)
             {
                 // db param Size set in StringConverter
                 dataParam.Size = s.Length;
             }
         }
 
-        protected virtual object GetValue<T>(FieldDefinition fieldDef, object obj)
+        protected virtual object GetValue(FieldDefinition fieldDef, object obj)
         {
             return GetFieldValue(fieldDef, fieldDef.GetValue(obj));
         }
@@ -1037,9 +1042,9 @@ public object GetFieldValue(Type fieldType, object value)
             }
         }
 
-        protected virtual object GetValueOrDbNull<T>(FieldDefinition fieldDef, object obj)
+        protected virtual object GetValueOrDbNull(FieldDefinition fieldDef, object obj)
         {
-            var value = GetValue<T>(fieldDef, obj);
+            var value = GetValue(fieldDef, obj);
             if (value == null)
                 return DBNull.Value;