Skip to content

Commit ba64a09

Browse files
Merge pull request #552 from SciML/Vaibhavdixit02-patch-3
Bring back AbstractRule in OptimizationOptimisers
2 parents bd5779c + fc97e95 commit ba64a09

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

lib/OptimizationOptimisers/src/OptimizationOptimisers.jl

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,9 @@ using Reexport, Printf, ProgressLogging
44
@reexport using Optimisers, Optimization
55
using Optimization.SciMLBase
66

7-
const OptimisersOptimizers = Union{Descent, Adam, Momentum, Nesterov, RMSProp,
8-
AdaGrad, AdaMax, AdaDelta, AMSGrad, NAdam, RAdam, OAdam,
9-
AdaBelief,
10-
WeightDecay, ClipGrad, ClipNorm, OptimiserChain}
7+
SciMLBase.supports_opt_cache_interface(opt::AbstractRule) = true
118

12-
SciMLBase.supports_opt_cache_interface(opt::OptimisersOptimizers) = true
13-
14-
function SciMLBase.__init(prob::SciMLBase.OptimizationProblem, opt::OptimisersOptimizers,
9+
function SciMLBase.__init(prob::SciMLBase.OptimizationProblem, opt::AbstractRule,
1510
data = Optimization.DEFAULT_DATA; save_best = true,
1611
callback = (args...) -> (false),
1712
progress = false, kwargs...)
@@ -40,7 +35,7 @@ function SciMLBase.__solve(cache::OptimizationCache{
4035
UC,
4136
S,
4237
O <:
43-
OptimisersOptimizers,
38+
AbstractRule,
4439
D,
4540
P,
4641
C,

0 commit comments

Comments
 (0)