Merge pull request #679 from SciML/myb/name

Escape state names for `f.sym`

Author: YingboMa

Project.toml

@@ -1,7 +1,7 @@
 name = "ModelingToolkit"
 uuid = "961ee093-0014-501f-94e3-6117800e7a78"
 authors = ["Chris Rackauckas <accounts@chrisrackauckas.com>"]
-version = "4.0.8"
+version = "4.0.9"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/systems/diffeqs/abstractodesystem.jl

@@ -158,13 +158,12 @@ function DiffEqBase.ODEFunction{iip}(sys::AbstractODESystem, dvs = states(sys),
 
     _M = (u0 === nothing || M == I) ? M : ArrayInterface.restructure(u0 .* u0',M)
 
-    sts = states(sys)
     ODEFunction{iip}(f,
                      jac = _jac === nothing ? nothing : _jac,
                      tgrad = _tgrad === nothing ? nothing : _tgrad,
                      mass_matrix = _M,
                      jac_prototype = sparse ? similar(sys.jac[],Float64) : nothing,
-                     syms = tosymbol.(sts, states=sts, escape=false))
+                     syms = Symbol.(states(sys)))
 end
 
 """
@@ -215,7 +214,6 @@ function ODEFunctionExpr{iip}(sys::AbstractODESystem, dvs = states(sys),
 
     jp_expr = sparse ? :(similar($(sys.jac[]),Float64)) : :nothing
 
-    sts = states(sys)
     ex = quote
         f = $f
         tgrad = $_tgrad
@@ -226,7 +224,7 @@ function ODEFunctionExpr{iip}(sys::AbstractODESystem, dvs = states(sys),
                          tgrad = tgrad,
                          mass_matrix = M,
                          jac_prototype = $jp_expr,
-                         syms = $(tosymbol.(sts, states=sts, escape=false)))
+                         syms = $(Symbol.(states(sys))))
     end
     !linenumbers ? striplines(ex) : ex
 end

src/systems/diffeqs/sdesystem.jl

@@ -197,7 +197,7 @@ function DiffEqBase.SDEFunction{iip}(sys::SDESystem, dvs = sys.states, ps = sys.
                      Wfact = _Wfact === nothing ? nothing : _Wfact,
                      Wfact_t = _Wfact_t === nothing ? nothing : _Wfact_t,
                      mass_matrix = _M,
-                     syms = tosymbol.(sts, states=sts, escape=false))
+                     syms = Symbol.(sys.states))
 end
 
 function DiffEqBase.SDEFunction(sys::SDESystem, args...; kwargs...)
@@ -255,7 +255,6 @@ function SDEFunctionExpr{iip}(sys::SDESystem, dvs = states(sys),
 
     _M = (u0 === nothing || M == I) ? M : ArrayInterface.restructure(u0 .* u0',M)
 
-    sts = states(sys)
     ex = quote
         f = $f
         g = $g
@@ -270,7 +269,7 @@ function SDEFunctionExpr{iip}(sys::SDESystem, dvs = states(sys),
                          Wfact = Wfact,
                          Wfact_t = Wfact_t,
                          mass_matrix = M,
-                         syms = $(tosymbol.(sts, states=sts, escape=false)),kwargs...)
+                         syms = $(Symbol.(states(sys))),kwargs...)
     end
     !linenumbers ? striplines(ex) : ex
 end

src/systems/jumps/jumpsystem.jl

@@ -197,8 +197,7 @@ function DiffEqBase.DiscreteProblem(sys::JumpSystem, u0map, tspan::Tuple,
         p = parammap
     end
     f  = DiffEqBase.DISCRETE_INPLACE_DEFAULT
-    sts = states(sys)
-    df = DiscreteFunction{true,true}(f, syms=tosymbol.(sts, states=sts, escape=false))
+    df = DiscreteFunction{true,true}(f, syms=Symbol.(states(sys)))
     DiscreteProblem(df, u0, tspan, p; kwargs...)
 end
 
@@ -226,13 +225,12 @@ function DiscreteProblemExpr(sys::JumpSystem, u0map, tspan::Tuple,
     u0 = varmap_to_vars(u0map, states(sys))
     p  = varmap_to_vars(parammap, parameters(sys))
     # identity function to make syms works
-    sts = states(sys)
     quote
         f  = DiffEqBase.DISCRETE_INPLACE_DEFAULT
         u0 = $u0
         p = $p
         tspan = $tspan
-        df = DiscreteFunction{true,true}(f, syms=$(tosymbol.(sts, states=sts, escape=false)))
+        df = DiscreteFunction{true,true}(f, syms=$(Symbol.(states(sys))))
         DiscreteProblem(df, u0, tspan, p; kwargs...)
     end
 end