Fix tests

Author: avik-pal

Project.toml

@@ -103,6 +103,7 @@ Setfield = "1"
 SparseArrays = "1.9"
 Sparspak = "0.3.6"
 StaticArraysCore = "1"
+StaticArrays = "1"
 Test = "1"
 UnPack = "1"
 julia = "1.9"
@@ -128,7 +129,8 @@ Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
 SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
+StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["Aqua", "Test", "IterativeSolvers", "InteractiveUtils", "JET", "KrylovKit", "Pkg", "Random", "SafeTestsets", "MultiFloats", "ForwardDiff", "HYPRE", "MPI", "BlockDiagonals", "Enzyme", "FiniteDiff", "BandedMatrices", "FastAlmostBandedMatrices"]
+test = ["Aqua", "Test", "IterativeSolvers", "InteractiveUtils", "JET", "KrylovKit", "Pkg", "Random", "SafeTestsets", "MultiFloats", "ForwardDiff", "HYPRE", "MPI", "BlockDiagonals", "Enzyme", "FiniteDiff", "BandedMatrices", "FastAlmostBandedMatrices", "StaticArrays"]

src/factorization.jl

@@ -286,10 +286,14 @@ else
     end
 end
 
-function init_cacheval(alg::CholeskyFactorization, A::SMatrix, b, u, Pl, Pr,
+function init_cacheval(alg::CholeskyFactorization, A::SMatrix{S1, S2}, b, u, Pl, Pr,
     maxiters::Int, abstol, reltol, verbose::Bool,
-    assumptions::OperatorAssumptions)
-    cholesky(SMatrix{1, 1}(one(eltype(A))))  # StaticArrays doesn't have the pivot argument. Prevent generic fallback.
+    assumptions::OperatorAssumptions) where {S1, S2}
+    # StaticArrays doesn't have the pivot argument. Prevent generic fallback.
+    # CholeskyFactorization is part of DefaultLinearSolver, so it is possible that `A` is
+    # not Hermitian.
+    (!issquare(A) || !ishermitian(A)) && return nothing
+    cholesky(A)
 end
 
 function init_cacheval(alg::CholeskyFactorization, A, b, u, Pl, Pr,

test/default_algs.jl

@@ -50,7 +50,7 @@ solve(prob)
     A = rand(4, 4)
     b = rand(4)
     prob = LinearProblem(A, b)
-    JET.@test_opt init(prob, nothing)
+    VERSION ≥ v"1.10-" && JET.@test_opt init(prob, nothing)
     JET.@test_opt solve(prob, LUFactorization())
     JET.@test_opt solve(prob, GenericLUFactorization())
     @test_skip JET.@test_opt solve(prob, QRFactorization())

test/static_arrays.jl

@@ -6,7 +6,6 @@ b = SVector{5}(rand(5))
 for alg in (nothing, LUFactorization(), SVDFactorization(), CholeskyFactorization(),
     KrylovJL_GMRES())
     sol = solve(LinearProblem(A, b), alg)
-    @show norm(A * sol .- b)
     @test norm(A * sol .- b) < 1e-10
 end