patch default for CUDA

Author: ChrisRackauckas

Project.toml

@@ -1,7 +1,7 @@
 name = "LinearSolve"
 uuid = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
 authors = ["SciML"]
-version = "1.0.0"
+version = "1.0.1"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/default.jl

@@ -43,7 +43,7 @@ function SciMLBase.solve(cache::LinearCache, alg::Nothing,
     # This catches the case where A is a CuMatrix
     # Which does not have LU fully defined
     elseif !(A isa AbstractDiffEqOperator)
-        alg = QRFactorization()
+        alg = QRFactorization(false)
         SciMLBase.solve(cache, alg, args...; kwargs...)
 
     # Not factorizable operator, default to only using A*x
@@ -98,7 +98,7 @@ function init_cacheval(alg::Nothing, A, b, u, Pl, Pr, maxiters, abstol, reltol,
     # This catches the case where A is a CuMatrix
     # Which does not have LU fully defined
     elseif !(A isa AbstractDiffEqOperator)
-        alg = QRFactorization()
+        alg = QRFactorization(false)
         init_cacheval(alg, A, b, u, Pl, Pr, maxiters, abstol, reltol, verbose)
 
     # Not factorizable operator, default to only using A*x

src/factorization.jl

@@ -129,15 +129,16 @@ end
 struct QRFactorization{P} <: AbstractFactorization
     pivot::P
     blocksize::Int
+    inplace::Bool
 end
 
-function QRFactorization()
+function QRFactorization(inplace = true)
     pivot = @static if VERSION < v"1.7beta"
         Val(false)
     else
         NoPivot()
     end
-    QRFactorization(pivot, 16)
+    QRFactorization(pivot, 16, inplace)
 end
 
 function do_factorization(alg::QRFactorization, A, b, u)
@@ -147,7 +148,11 @@ function do_factorization(alg::QRFactorization, A, b, u)
     if A isa AbstractDiffEqOperator
         A = A.A
     end
-    fact = qr!(A, alg.pivot; blocksize = alg.blocksize)
+    if alg.inplace
+        fact = qr!(A, alg.pivot; blocksize = alg.blocksize)
+    else
+        fact = qr(A) # CUDA.jl does not allow other args!
+    end
     return fact
 end