@@ -309,6 +309,38 @@ def test_multiple_column_comments(make_mocked_engine_adapter: t.Callable, mocker
309309 ]
310310
311311
312+ def test_column_comments_iceberg (make_mocked_engine_adapter : t .Callable ):
313+ adapter = make_mocked_engine_adapter (SnowflakeEngineAdapter )
314+
315+ adapter ._create_column_comments (
316+ "test_table" ,
317+ {"a" : "a column description" , "b" : "b column description" },
318+ table_format = "iceberg" ,
319+ )
320+
321+ assert to_sql_calls (adapter ) == [
322+ """ALTER ICEBERG TABLE "test_table" ALTER COLUMN "a" COMMENT 'a column description', COLUMN "b" COMMENT 'b column description'""" ,
323+ ]
324+
325+
326+ def test_ctas_column_comments_iceberg (make_mocked_engine_adapter : t .Callable ):
327+ adapter = make_mocked_engine_adapter (SnowflakeEngineAdapter )
328+
329+ # The column types are unknown, so the comments can't be inlined into the CTAS
330+ # schema definition and are registered with a post-creation ALTER instead
331+ adapter .ctas (
332+ "test_table" ,
333+ parse_one ("SELECT a, b FROM source_table" ),
334+ table_format = "iceberg" ,
335+ column_descriptions = {"a" : "a column description" },
336+ )
337+
338+ assert to_sql_calls (adapter ) == [
339+ """CREATE ICEBERG TABLE IF NOT EXISTS "test_table" AS SELECT "a", "b" FROM "source_table\" """ ,
340+ """ALTER ICEBERG TABLE "test_table" ALTER COLUMN "a" COMMENT 'a column description'""" ,
341+ ]
342+
343+
312344def test_sync_grants_config (make_mocked_engine_adapter : t .Callable , mocker : MockerFixture ):
313345 adapter = make_mocked_engine_adapter (SnowflakeEngineAdapter )
314346 relation = normalize_identifiers (
@@ -637,6 +669,31 @@ def test_create_managed_table(make_mocked_engine_adapter: t.Callable, mocker: Mo
637669 ]
638670
639671
672+ @pytest .mark .parametrize ("table_format" , [None , "iceberg" ])
673+ def test_create_managed_table_column_comments (
674+ make_mocked_engine_adapter : t .Callable , table_format : t .Optional [str ]
675+ ):
676+ adapter = make_mocked_engine_adapter (SnowflakeEngineAdapter )
677+
678+ # Unknown column types require a post-creation comment command.
679+ adapter .create_managed_table (
680+ table_name = "test_table" ,
681+ query = parse_one ("SELECT a, b FROM source_table" ),
682+ table_format = table_format ,
683+ table_properties = {
684+ "target_lag" : exp .Literal .string ("20 minutes" ),
685+ "warehouse" : exp .to_identifier ("test_warehouse" ),
686+ },
687+ column_descriptions = {"a" : "a column description" , "b" : "b column description" },
688+ )
689+
690+ table_kind = "DYNAMIC ICEBERG TABLE" if table_format else "DYNAMIC TABLE"
691+ assert to_sql_calls (adapter ) == [
692+ f'CREATE OR REPLACE { table_kind } "test_table" TARGET_LAG=\' 20 minutes\' WAREHOUSE="test_warehouse" AS SELECT "a", "b" FROM "source_table"' ,
693+ """ALTER TABLE "test_table" ALTER COLUMN "a" COMMENT 'a column description', COLUMN "b" COMMENT 'b column description'""" ,
694+ ]
695+
696+
640697def test_drop_managed_table (make_mocked_engine_adapter : t .Callable , mocker : MockerFixture ):
641698 adapter = make_mocked_engine_adapter (SnowflakeEngineAdapter )
642699
0 commit comments