Widen types instead of casting

Author: VaggelisD

sqlmesh/core/context.py

@@ -1860,10 +1860,10 @@ def table_diff(
         self,
         source: str,
         target: str,
-        on: t.Optional[t.List[str] | exp.Condition] = None,
+        on: t.Optional[t.List[str] | exp.Expr] = None,
         skip_columns: t.Optional[t.List[str]] = None,
         select_models: t.Optional[t.Collection[str]] = None,
-        where: t.Optional[str | exp.Condition] = None,
+        where: t.Optional[str | exp.Expr] = None,
         limit: int = 20,
         show: bool = True,
         show_sample: bool = True,
@@ -1922,7 +1922,7 @@ def table_diff(
                 raise SQLMeshError(e)
 
             models_to_diff: t.List[
-                t.Tuple[Model, EngineAdapter, str, str, t.Optional[t.List[str] | exp.Condition]]
+                t.Tuple[Model, EngineAdapter, str, str, t.Optional[t.List[str] | exp.Expr]]
             ] = []
             models_without_grain: t.List[Model] = []
             source_snapshots_to_name = {
@@ -2041,9 +2041,9 @@ def _model_diff(
         target_alias: str,
         limit: int,
         decimals: int,
-        on: t.Optional[t.List[str] | exp.Condition] = None,
+        on: t.Optional[t.List[str] | exp.Expr] = None,
         skip_columns: t.Optional[t.List[str]] = None,
-        where: t.Optional[str | exp.Condition] = None,
+        where: t.Optional[str | exp.Expr] = None,
         show: bool = True,
         temp_schema: t.Optional[str] = None,
         skip_grain_check: bool = False,
@@ -2083,10 +2083,10 @@ def _table_diff(
         limit: int,
         decimals: int,
         adapter: EngineAdapter,
-        on: t.Optional[t.List[str] | exp.Condition] = None,
+        on: t.Optional[t.List[str] | exp.Expr] = None,
         model: t.Optional[Model] = None,
         skip_columns: t.Optional[t.List[str]] = None,
-        where: t.Optional[str | exp.Condition] = None,
+        where: t.Optional[str | exp.Expr] = None,
         schema_diff_ignore_case: bool = False,
     ) -> TableDiff:
         if not on:

sqlmesh/core/table_diff.py

@@ -224,9 +224,9 @@ def __init__(
         adapter: EngineAdapter,
         source: TableName,
         target: TableName,
-        on: t.List[str] | exp.Condition,
+        on: t.List[str] | exp.Expr,
         skip_columns: t.List[str] | None = None,
-        where: t.Optional[str | exp.Condition] = None,
+        where: t.Optional[str | exp.Expr] = None,
         limit: int = 20,
         source_alias: t.Optional[str] = None,
         target_alias: t.Optional[str] = None,

sqlmesh/lsp/main.py

@@ -374,7 +374,7 @@ def _custom_api(
                     table_diffs = context.context.table_diff(
                         source=source,
                         target=target,
-                        on=t.cast(exp.Condition, exp.condition(on)) if on else None,
+                        on=exp.condition(on) if on else None,
                         select_models={model_or_snapshot} if model_or_snapshot else None,
                         where=where,
                         limit=limit,