Skip to content

Commit 38717ab

Browse files
committed
refactoring after upgrading server dependencies
1 parent 982e7c3 commit 38717ab

File tree

8 files changed

+27
-20
lines changed

8 files changed

+27
-20
lines changed

api/src/main/resources/reference.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ include "softnetwork-jdbc-persistence.conf"
22
include "softnetwork-scheduler.conf"
33

44
softnetwork.api.name = "softnetwork-scheduler"
5-
softnetwork.api.version = "0.3.2.3"
5+
softnetwork.api.version = "0.3.5"
66
softnetwork.api.server.port = 9000
77
softnetwork.api.server.request-timeout = 120 s
88
softnetwork.api.server.swagger-path-prefix = ["swagger", "scheduler"]

core/src/main/scala/app/softnetwork/scheduler/launch/SchedulerEndpoints.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,6 @@ trait SchedulerEndpoints extends ApiEndpoints with SchedulerGuardian { _: Schema
1313
def schedulerEndpoints: ActorSystem[_] => SchedulerServiceEndpoints = system =>
1414
SchedulerServiceEndpoints.apply(system, sessionEndpoints(system))
1515

16-
override def endpoints: ActorSystem[_] => List[ApiEndpoint] = system => List(schedulerEndpoints(system))
16+
override def endpoints: ActorSystem[_] => List[ApiEndpoint] = system =>
17+
List(schedulerEndpoints(system))
1718
}

core/src/main/scala/app/softnetwork/scheduler/launch/SchedulerRoutes.scala

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package app.softnetwork.scheduler.launch
22

33
import akka.actor.typed.ActorSystem
44
import akka.http.scaladsl.server.Route
5-
import app.softnetwork.api.server.ApiRoutes
5+
import app.softnetwork.api.server.{ApiRoute, ApiRoutes}
66
import app.softnetwork.persistence.schema.SchemaProvider
77
import app.softnetwork.scheduler.service.SchedulerService
88
import app.softnetwork.session.service.SessionService
@@ -14,6 +14,10 @@ trait SchedulerRoutes extends ApiRoutes with SchedulerGuardian { _: SchemaProvid
1414
def schedulerService: ActorSystem[_] => SchedulerService = system =>
1515
SchedulerService(system, sessionService(system))
1616

17-
override def apiRoutes(system: ActorSystem[_]): Route = schedulerService(system).route
17+
override def apiRoutes: ActorSystem[_] => List[ApiRoute] =
18+
system =>
19+
List(
20+
schedulerService(system)
21+
)
1822

1923
}

core/src/main/scala/app/softnetwork/scheduler/service/SchedulerService.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ trait SchedulerService
2727
with StrictLogging
2828
with Service[SchedulerCommand, SchedulerCommandResult]
2929
with SchedulerDao
30-
with SchedulerHandler {
30+
with SchedulerHandler
31+
with ApiRoute {
3132

3233
implicit def serialization: Serialization.type = jackson.Serialization
3334

core/src/main/scala/app/softnetwork/scheduler/service/SchedulerServiceEndpoints.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,6 @@ trait SchedulerServiceEndpoints
170170
loadSchedulerEndpoint
171171
)
172172

173-
lazy val route: Route = apiRoute
174173
}
175174

176175
object SchedulerServiceEndpoints {

project/src/main/scala/app/softnetwork/sbt/build/Versions.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package app.softnetwork.sbt.build
22

33
object Versions {
44

5-
val genericPersistence = "0.3.4"
5+
val genericPersistence = "0.3.5"
66

77
val scalatest = "3.1.1"
88
}

testkit/src/main/scala/app/softnetwork/scheduler/scalatest/SchedulerEndpointsTestKit.scala

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,13 @@ package app.softnetwork.scheduler.scalatest
22

33
import akka.actor.typed.ActorSystem
44
import app.softnetwork.api.server.ApiEndpoint
5-
import app.softnetwork.scheduler.service.SchedulerServiceEndpoints
5+
import app.softnetwork.persistence.schema.SchemaProvider
6+
import app.softnetwork.scheduler.launch.SchedulerEndpoints
67
import app.softnetwork.session.scalatest.SessionEndpointsRoutes
78
import com.softwaremill.session.CsrfCheck
89

9-
trait SchedulerEndpointsTestKit extends SessionEndpointsRoutes { _: CsrfCheck =>
10-
11-
def schedulerEndpoints: ActorSystem[_] => SchedulerServiceEndpoints = system =>
12-
SchedulerServiceEndpoints.apply(system, sessionEndpoints(system))
10+
trait SchedulerEndpointsTestKit extends SchedulerEndpoints with SessionEndpointsRoutes {
11+
_: SchemaProvider with CsrfCheck =>
1312

1413
override def endpoints: ActorSystem[_] => List[ApiEndpoint] =
1514
system =>
Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
11
package app.softnetwork.scheduler.scalatest
22

33
import akka.actor.typed.ActorSystem
4-
import akka.http.scaladsl.server.Route
5-
import app.softnetwork.scheduler.service.SchedulerService
4+
import app.softnetwork.api.server.ApiRoute
5+
import app.softnetwork.persistence.schema.SchemaProvider
6+
import app.softnetwork.scheduler.launch.SchedulerRoutes
67
import app.softnetwork.session.scalatest.SessionServiceRoutes
78

8-
trait SchedulerRoutesTestKit extends SessionServiceRoutes {
9+
trait SchedulerRoutesTestKit extends SchedulerRoutes with SessionServiceRoutes {
10+
_: SchemaProvider =>
911

10-
def schedulerService: ActorSystem[_] => SchedulerService = system =>
11-
SchedulerService(system, sessionService(system))
12-
13-
override def apiRoutes(system: ActorSystem[_]): Route =
14-
sessionServiceRoute(system).route ~ schedulerService(system).route
12+
override def apiRoutes: ActorSystem[_] => List[ApiRoute] =
13+
system =>
14+
List(
15+
sessionServiceRoute(system),
16+
schedulerService(system)
17+
)
1518

1619
}

0 commit comments

Comments
 (0)