Skip to content

Commit 6105283

Browse files
committed
remove stopOffset - register database shutdown on termination for Slick
1 parent 36bc357 commit 6105283

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

core/src/main/scala/app/softnetwork/persistence/query/OffsetProvider.scala

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,4 @@ trait OffsetProvider { _: EventStream =>
3131
*/
3232
protected def writeOffset(offset: Offset): Future[Done]
3333

34-
protected def stopOffset(): Unit = ()
35-
36-
sys.addShutdownHook(stopOffset())
37-
3834
}

jdbc/src/main/scala/app/softnetwork/persistence/jdbc/db/SlickDatabase.scala

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,17 @@ trait SlickDatabase extends ClasspathResources {
2424

2525
lazy val db: Database = {
2626
log.info(profile)
27-
SlickExtension(classicSystem).database(config).database
27+
val db = SlickExtension(classicSystem).database(config).database
28+
classicSystem.registerOnTermination(shutdown())
29+
db
2830
}
2931

30-
sys.addShutdownHook(shutdown())
31-
3232
def shutdown(): Unit = {
3333
log.info(s"Shutting down database")
34-
db.shutdown
34+
Try(db.shutdown) match {
35+
case Success(_) =>
36+
case Failure(f) => log.error(f.getMessage)
37+
}
3538
}
3639

3740
def withFile(file: String, separator: String = ";"): Unit = {

jdbc/src/main/scala/app/softnetwork/persistence/jdbc/query/JdbcOffsetProvider.scala

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,4 @@ trait JdbcOffsetProvider extends OffsetProvider with SlickDatabase { _: EventStr
134134
}
135135
}
136136

137-
override protected def stopOffset(): Unit = {
138-
log.info("Stopping Offset")
139-
session.close()
140-
}
141137
}

0 commit comments

Comments
 (0)