Skip to content

Commit b38f3a1

Browse files
committed
update TODO's/comments
1 parent 2e5e80a commit b38f3a1

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

internal/cluster/factory.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ func (f *ClientFactory) Get(kubeConfig []byte, impersonationUser string, imperso
147147
f.clients[key] = client
148148

149149
// TODO: add some (debug) log output when new client is created; unfortunately, we have no logger in here ...
150+
// maybe we could (at least in Get()) get one from the reconcile context ...
150151
// TODO: add metrics about running clients
151152
return client, nil
152153
}

internal/cluster/types.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import (
1212
)
1313

1414
// TODO: the Client interface should be public, because it is returned by component.GetClientFromContext()
15+
// TODO: should we add a Config() method, i.e. expose the rest.Config used by the client?
1516

1617
// The Client interface extends the controller-runtime client by discovery and event recording capabilities.
1718
type Client interface {

0 commit comments

Comments
 (0)