Skip to content

Commit 8603504

Browse files
committed
add comment
1 parent ccd8d00 commit 8603504

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pkg/reconciler/util.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,8 +241,9 @@ func sortObjectsForApply[T client.Object](s []T, orderFunc func(client.Object) i
241241

242242
func sortObjectsForDelete(inventory []*InventoryItem) []*InventoryItem {
243243
priority := map[string]int{
244-
"CustomResourceDefinition.apiextensions.k8s.io": -1,
245-
"APIService.apiregistration.k8s.io": -1,
244+
"CustomResourceDefinition.apiextensions.k8s.io": -1,
245+
"APIService.apiregistration.k8s.io": -1,
246+
// TODO: should webhook configurations be deleted before order-zero objects?
246247
"ValidatingWebhookConfiguration.admissionregistration.k8s.io": 1,
247248
"MutatingWebhookConfiguration.admissionregistration.k8s.io": 1,
248249
"Service": 2,

0 commit comments

Comments
 (0)