Skip to content

Commit 5cf9db1

Browse files
committed
add comments
1 parent 5c2d50d commit 5cf9db1

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

pkg/component/reconciler.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@ import (
4444
)
4545

4646
// TODO: in general add more retry to overcome 409 update errors (also etcd storage errors because of missed precondition on delete)
47-
// TODO: make a can-i check before emitting events to deployment target (e.g. in the client factory when creating the client)
47+
// TODO: emitting events to deployment target may fail if corresponding rbac privileges are missing; either this should be pre-discovered or we
48+
// should stop emitting events to remote targets at all; howerver pre-discovering is difficult (may vary from object to object); one option could
49+
// be to send events only if we are cluster-admin
4850
// TODO: allow to override namespace auto-creation and policies on a per-component level
4951
// (e.g. through annotations or another interface that components could optionally implement)
5052
// TODO: allow to override namespace auto-creation on a per-object level

pkg/reconciler/reconciler.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1005,6 +1005,7 @@ func (r *Reconciler) updateObject(ctx context.Context, object client.Object, exi
10051005
return err
10061006
} else if changed {
10071007
log.V(1).Info("adjusting field managers as preparation of ssa")
1008+
// TODO: add a metric to count if this happens
10081009
gvk := object.GetObjectKind().GroupVersionKind()
10091010
obj := &metav1.PartialObjectMetadata{
10101011
TypeMeta: metav1.TypeMeta{

0 commit comments

Comments
 (0)