do not force-reapply if reconcile policy is "once" (#300)

* do not force-reapply if reconcile policy is "once"

* fix typo (quotes)

Author: cbarbian-sap

pkg/reconciler/reconciler.go

@@ -58,6 +58,10 @@ const (
 	maxOrder = math.MaxInt16
 )
 
+const (
+	digestOnce = "__once__"
+)
+
 const (
 	defaultReapplyInterval = 60 * time.Minute
 )
@@ -719,6 +723,7 @@ func (r *Reconciler) Apply(ctx context.Context, inventory *[]*InventoryItem, obj
 					item.LastAppliedAt = &metav1.Time{Time: now}
 					numUnready++
 				} else if existingObject.GetDeletionTimestamp().IsZero() &&
+					(existingObject.GetAnnotations()[r.annotationKeyDigest] != digestOnce || item.Digest != digestOnce) &&
 					(existingObject.GetAnnotations()[r.annotationKeyDigest] != item.Digest || item.LastAppliedAt == nil || item.LastAppliedAt.Time.Before(now.Add(-reapplyInterval))) {
 					switch updatePolicy {
 					case UpdatePolicyRecreate:

pkg/reconciler/util.go

@@ -60,7 +60,7 @@ func checkRange(x int, min int, max int) error {
 
 func calculateObjectDigest(obj client.Object, componentDigest string, reconcilePolicy ReconcilePolicy) (string, error) {
 	if reconcilePolicy == ReconcilePolicyOnce {
-		return "__once__", nil
+		return digestOnce, nil
 	}
 
 	resourceVersion := obj.GetResourceVersion()