Skip to content

Commit f4799a0

Browse files
Using both logback and log4j2 frameworks for testing
- component `cf-java-logging-support-jersey` would use `log4j2` for its tests - earlier all components used `logback` for tests
1 parent 8e78795 commit f4799a0

File tree

4 files changed

+35
-24
lines changed

4 files changed

+35
-24
lines changed

cf-java-logging-support-jersey/pom.xml

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,21 +26,21 @@
2626
<version>${jersey.version}</version>
2727
<scope>provided</scope>
2828
</dependency>
29-
29+
3030
<dependency>
3131
<groupId>org.glassfish.jersey.core</groupId>
3232
<artifactId>jersey-server</artifactId>
3333
<version>${jersey.version}</version>
3434
<scope>provided</scope>
3535
</dependency>
36-
36+
3737
<dependency>
3838
<groupId>com.sap.hcp.cf.logging</groupId>
3939
<artifactId>cf-java-logging-support-core</artifactId>
4040
<version>${project.version}</version>
4141
<scope>compile</scope>
4242
</dependency>
43-
43+
4444
<!-- unit test related -->
4545
<dependency>
4646
<groupId>org.glassfish.jersey.test-framework</groupId>
@@ -55,18 +55,24 @@
5555
<version>${jersey.version}</version>
5656
<scope>test</scope>
5757
</dependency>
58-
<!-- we need our logback implementation for testing! -->
58+
<!-- we need our log4j2 implementation for testing! -->
5959
<dependency>
60-
<groupId>com.sap.hcp.cf.logging</groupId>
61-
<artifactId>cf-java-logging-support-logback</artifactId>
62-
<version>${project.version}</version>
60+
<groupId>com.sap.hcp.cf.logging</groupId>
61+
<artifactId>cf-java-logging-support-log4j2</artifactId>
62+
<version>${project.version}</version>
6363
<scope>test</scope>
64-
</dependency>
64+
</dependency>
6565
<dependency>
66-
<groupId>ch.qos.logback</groupId>
67-
<artifactId>logback-classic</artifactId>
68-
<version>${logback.version}</version>
66+
<groupId>org.apache.logging.log4j</groupId>
67+
<artifactId>log4j-slf4j-impl</artifactId>
68+
<version>${log4j2.version}</version>
6969
<scope>test</scope>
70-
</dependency>
70+
</dependency>
71+
<dependency>
72+
<groupId>org.apache.logging.log4j</groupId>
73+
<artifactId>log4j-core</artifactId>
74+
<version>${log4j2.version}</version>
75+
<scope>test</scope>
76+
</dependency>
7177
</dependencies>
7278
</project>
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<Configuration status="warn" strict="true" packages="com.sap.hcp.cf.log4j2.converter,com.sap.hcp.cf.log4j2.layout">
3+
<Appenders>
4+
<Console name="STDOUT-JSON" target="SYSTEM_OUT" follow="true">
5+
<JsonPatternLayout charset="utf-8"/>
6+
</Console>
7+
</Appenders>
8+
<Loggers>
9+
<Root level="${LOG_ROOT_LEVEL:-WARN}">
10+
<AppenderRef ref="STDOUT-JSON" />
11+
</Root>
12+
<Logger name="com.sap.hcp.cf" level="INFO"/>
13+
</Loggers>
14+
</Configuration>

cf-java-logging-support-jersey/src/test/resources/logback-test.xml

Lines changed: 0 additions & 10 deletions
This file was deleted.

pom.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,9 @@
7878
<properties>
7979
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
8080
<jackson-jr.version>2.6.3</jackson-jr.version>
81-
<slf4j.version>1.7.10</slf4j.version>
82-
<logback.version>1.1.3</logback.version>
81+
<slf4j.version>LATEST</slf4j.version>
82+
<logback.version>LATEST</logback.version>
83+
<log4j2.version>LATEST</log4j2.version>
8384
<buildnumber.plugin.version>1.3</buildnumber.plugin.version>
8485
<source.plugin.version>2.4</source.plugin.version>
8586
<jar.plugin.version>2.4</jar.plugin.version>

0 commit comments

Comments
 (0)