Fix Java issues and warnings

Change-Id: I43272649f8a4c260ffb59a88d09644d372cfd0d8

Author: ChristophEichhorn

cf-java-logging-support-core/src/main/java/com/sap/hcp/cf/logging/common/DateTimeValue.java

@@ -16,11 +16,14 @@ public class DateTimeValue implements Value {
     private static final TimeZone UTC_TZ = TimeZone.getTimeZone("UTC");
     private static final DateFormat DATE_FORMAT = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'");
 
+    static {
+        DATE_FORMAT.setTimeZone(UTC_TZ);
+    }
+
     private long timestamp;
 
     public DateTimeValue(long timestamp) {
         this.timestamp = timestamp;
-        DATE_FORMAT.setTimeZone(UTC_TZ);
     }
 
     public DateTimeValue(String dt) {

cf-java-logging-support-log4j2/src/test/java/com/sap/hcp/cf/logging/common/AbstractTest.java

@@ -50,6 +50,7 @@ protected String getField(String fieldName) {
         }
     }
 
+    @SuppressWarnings("unchecked")
     protected List<String> getList(String fieldName) {
         try {
             return (List<String>) JSON.std.mapFrom(getLastLine()).get(fieldName);

cf-java-logging-support-logback/src/main/java/com/sap/hcp/cf/logback/converter/CategoriesConverter.java

@@ -46,9 +46,9 @@ private void getMarkers(Marker marker, StringBuilder appendTo) {
     private void getMarkersRecursively(Marker marker, ArrayComposer<JSONComposer<String>> ac) throws IOException {
         if (marker != null) {
             ac.add(marker.getName());
-            Iterator it = marker.iterator();
+            Iterator<Marker> it = marker.iterator();
             while (it.hasNext()) {
-                getMarkersRecursively((Marker) it.next(), ac);
+                getMarkersRecursively(it.next(), ac);
             }
         }
     }

cf-java-logging-support-logback/src/test/java/com/sap/hcp/cf/logging/common/AbstractTest.java

@@ -46,6 +46,7 @@ protected String getField(String fieldName) {
         }
     }
 
+    @SuppressWarnings("unchecked")
     protected List<String> getList(String fieldName) {
         try {
             return (List<String>) JSON.std.mapFrom(lastLine()).get(fieldName);

cf-java-logging-support-logback/src/test/java/com/sap/hcp/cf/logging/common/TestAppLog.java

@@ -63,7 +63,6 @@ public void testMDC() {
         logMsg = "Running testMDC()";
         long beforeTS = System.nanoTime();
         LOGGER.info(logMsg);
-        long afterTS = System.nanoTime();
         assertThat(getMessage(), is(logMsg));
         assertThat(getField(Fields.COMPONENT_ID), is("-"));
         assertThat(getField(Fields.COMPONENT_NAME), is("-"));

cf-java-logging-support-servlet/src/main/java/com/sap/hcp/cf/logging/servlet/filter/ContentLengthTrackingRequestWrapper.java

@@ -12,7 +12,6 @@
  */
 public class ContentLengthTrackingRequestWrapper extends HttpServletRequestWrapper {
 
-    private final HttpServletRequest request;
     private WrappedInputReader wrappedReader = null;
     private WrappedInputStream wrappedStream = null;
 
@@ -25,7 +24,6 @@ public class ContentLengthTrackingRequestWrapper extends HttpServletRequestWrapp
      */
     public ContentLengthTrackingRequestWrapper(HttpServletRequest request) {
         super(request);
-        this.request = request;
     }
 
     @Override

sample/src/main/java/com/iamjambay/cloudfoundry/stickysession/MainServlet.java

@@ -6,7 +6,6 @@
 import java.math.BigInteger;
 import java.util.Enumeration;
 import java.util.Map.Entry;
-import java.util.Random;
 
 import javax.servlet.ServletException;
 import javax.servlet.http.Cookie;
@@ -24,7 +23,6 @@ public class MainServlet extends HttpServlet {
     private static final long serialVersionUID = 1L;
     private static final String CF_INSTANCE_INDEX = "CF_INSTANCE_INDEX";
     private final Logger logger = LoggerFactory.getLogger(MainServlet.class);
-    private final Random random = new Random();
     private static final String STACKTRACE = "/stacktrace";
 
     public MainServlet() {
@@ -105,10 +103,6 @@ private void printFibonacci(PrintWriter writer, String qs) {
         }
     }
 
-    private void logRequest(HttpServletRequest request) {
-        logger.info("Done processing request " + request.getRequestURI() + " from " + request.getRemoteHost());
-    }
-
     @Override
     protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException,
                                                                                    IOException {