Skip to content

Commit 27cac79

Browse files
Merge pull request #221 from KarstenSchnitter/release-4
Port Changes from Main to Release-4
2 parents 04725d4 + 31e7679 commit 27cac79

File tree

5 files changed

+27
-10
lines changed

5 files changed

+27
-10
lines changed

cf-java-logging-support-core/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<dependency>
2626
<groupId>org.apache.commons</groupId>
2727
<artifactId>commons-lang3</artifactId>
28-
<version>3.12.0</version>
28+
<version>3.18.0</version>
2929
</dependency>
3030
</dependencies>
3131

cf-java-logging-support-opentelemetry-agent-extension/pom.xml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<properties>
1919
<maven.compiler.source>11</maven.compiler.source>
2020
<maven.compiler.target>11</maven.compiler.target>
21-
<opentelemetry.sdk.version>1.31.0</opentelemetry.sdk.version>
21+
<opentelemetry.sdk.version>1.52.0</opentelemetry.sdk.version>
2222
</properties>
2323

2424
<dependencyManagement>
@@ -64,6 +64,12 @@
6464
<artifactId>jackson-core</artifactId>
6565
<version>${jackson-jr.version}</version>
6666
</dependency>
67+
<dependency>
68+
<groupId>com.squareup.okhttp3</groupId>
69+
<artifactId>okhttp</artifactId>
70+
<version>4.9.3</version>
71+
<scope>test</scope>
72+
</dependency>
6773
<dependency>
6874
<groupId>uk.org.webcompere</groupId>
6975
<artifactId>system-stubs-jupiter</artifactId>

cf-java-logging-support-opentelemetry-agent-extension/src/main/java/com/sap/hcf/cf/logging/opentelemetry/agent/ext/binding/CloudLoggingBindingPropertiesSupplier.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ private static ConfigProperties getDefaultProperties() {
3636
defaults.put("com.sap.otel.extension.cloud-logging.label", "cloud-logging");
3737
defaults.put("com.sap.otel.extension.cloud-logging.tag", "Cloud Logging");
3838
defaults.put("otel.javaagent.extension.sap.cf.binding.user-provided.label", "user-provided");
39-
return DefaultConfigProperties.create(defaults);
39+
return DefaultConfigProperties.createFromMap(defaults);
4040
}
4141

4242
private static boolean isBlank(String text) {

cf-java-logging-support-opentelemetry-agent-extension/src/test/java/com/sap/hcf/cf/logging/opentelemetry/agent/ext/attributes/CloudFoundryResourceCustomizerTest.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ public class CloudFoundryResourceCustomizerTest {
2323
@Test
2424
void emptyResourceWithNullResource() {
2525
CloudFoundryResourceCustomizer customizer = new CloudFoundryResourceCustomizer();
26-
Resource resource = customizer.apply(null, DefaultConfigProperties.create(new HashMap<>()));
26+
Resource resource = customizer.apply(null, DefaultConfigProperties.createFromMap(new HashMap<>()));
2727
assertTrue(resource.getAttributes().isEmpty());
2828
}
2929

3030
@Test
3131
void emptyResourceWhenNotInCf() {
3232
CloudFoundryResourceCustomizer customizer = new CloudFoundryResourceCustomizer();
3333
Resource resource =
34-
customizer.apply(Resource.builder().build(), DefaultConfigProperties.create(new HashMap<>()));
34+
customizer.apply(Resource.builder().build(), DefaultConfigProperties.createFromMap(new HashMap<>()));
3535
assertTrue(resource.getAttributes().isEmpty());
3636
}
3737

@@ -42,7 +42,8 @@ void emptyResourceWhenDisabledByProperty() {
4242
properties.put("otel.javaagent.extension.sap.cf.resource.enabled", "false");
4343

4444
CloudFoundryResourceCustomizer customizer = new CloudFoundryResourceCustomizer();
45-
Resource resource = customizer.apply(Resource.builder().build(), DefaultConfigProperties.create(properties));
45+
Resource resource =
46+
customizer.apply(Resource.builder().build(), DefaultConfigProperties.createFromMap(properties));
4647
assertTrue(resource.getAttributes().isEmpty());
4748
}
4849

@@ -51,7 +52,7 @@ void fillsResourceFromVcapApplication() {
5152

5253
CloudFoundryResourceCustomizer customizer = new CloudFoundryResourceCustomizer();
5354
Resource resource =
54-
customizer.apply(DEFAULT_CF_RESOURCE, DefaultConfigProperties.create(Collections.emptyMap()));
55+
customizer.apply(DEFAULT_CF_RESOURCE, DefaultConfigProperties.createFromMap(Collections.emptyMap()));
5556
assertStringAttribute(resource, "service.name").isEqualTo("test-application");
5657
assertStringAttribute(resource, "sap.cf.app_name").isEqualTo("test-application");
5758
assertStringAttribute(resource, "sap.cf.app_id").isEqualTo("test-app-id");
@@ -69,7 +70,7 @@ void keepsOriginalResourceOnOTelResourceFormat() {
6970
HashMap<String, String> config = new HashMap<String, String>() {{
7071
put("otel.javaagent.extension.sap.cf.resource.format", "opentelemetry");
7172
}};
72-
Resource resource = customizer.apply(DEFAULT_CF_RESOURCE, DefaultConfigProperties.create(config));
73+
Resource resource = customizer.apply(DEFAULT_CF_RESOURCE, DefaultConfigProperties.createFromMap(config));
7374

7475
assertEquals(DEFAULT_CF_RESOURCE, resource);
7576
}

pom.xml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@
128128
<httpclient.version>4.5.14</httpclient.version>
129129
<servlet.api.version>5.0.0</servlet.api.version>
130130
<jetty.version>11.0.14</jetty.version>
131+
<sonatype.plugin.version>0.8.0</sonatype.plugin.version>
131132
</properties>
132133

133134
<modules>
@@ -229,7 +230,7 @@
229230
</build>
230231
<profiles>
231232
<profile>
232-
<id>ossrh</id>
233+
<id>central</id>
233234
<build>
234235
<plugins>
235236
<plugin>
@@ -239,7 +240,7 @@
239240
<executions>
240241
<execution>
241242
<id>attach-sources</id>
242-
<phase>validate</phase>
243+
<phase>package</phase>
243244
<goals>
244245
<goal>jar-no-fork</goal>
245246
</goals>
@@ -274,6 +275,15 @@
274275
</execution>
275276
</executions>
276277
</plugin>
278+
<plugin>
279+
<groupId>org.sonatype.central</groupId>
280+
<artifactId>central-publishing-maven-plugin</artifactId>
281+
<version>${sonatype.plugin.version}</version>
282+
<extensions>true</extensions>
283+
<configuration>
284+
<publishingServerId>central</publishingServerId>
285+
</configuration>
286+
</plugin>
277287
</plugins>
278288
</build>
279289
</profile>

0 commit comments

Comments
 (0)