Skip to content

Ability to configure features passed to minimal-versions #15

@tarcieri

Description

@tarcieri

The minimal-versions shared workflow presently doesn't provide a way to pass the --exclude-features parameter to cargo hack.

This is problematic when using a 3rd party dependency which isn't minimal-versions-clean itself. In particular I'm experiencing this with ed25519-dalek:

https://github.com/RustCrypto/formats/runs/5739309796?check_suite_focus=true

It would be nice to opt out of minimal-versions in these cases by excluding the features from the workflow. While a "proper" fix is making the upstream dependency minimal-versions clean, it would be nice in the interim to still have the check work without having to list out the relevant dependencies in dev-dependencies.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions