-
Notifications
You must be signed in to change notification settings - Fork 1
PRD-1499: builder.infiniteQuery integration #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@RuslanAktaev please remove WIP status when you're ready |
|
@ipakhomov review please! |
ipakhomov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RuslanAktaev thank you for your PR. Please find my comments above
| > = { | ||
| create: MutationDefinition<Partial<TEntity>, BaseQueryFunction, string, TEntity>; | ||
| search: QueryDefinition<TSearchRequest, BaseQueryFunction, string, TSearchResponse>; | ||
| searchInfinite: QueryDefinition<TSearchRequest, BaseQueryFunction, string, TSearchResponse & { minPage?: number }>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mark this old endpoint as deprecated
|
@ipakhomov done! |
ipakhomov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RuslanAktaev looks good to me!
No description provided.