controller refactor

[RGO230]

#10

[AZabolotnikov]

why PR name "refactor: test"?
Task about controller refactoring.
Please rename PR.

[Copilot]

Pull Request Overview

This refactor introduces form request validation and API resource classes to improve structure and validation handling for the ExpoController endpoints. The changes replace manual validation and JSON response creation with Laravel's built-in form request validation and API resources.

• Adds form request classes (SubscribeRequest, UnsubscribeRequest) with validation rules
• Introduces API resource classes to standardize response formatting
• Updates ExpoController to use form requests and resources instead of manual validation

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
tests/ExpoControllerTest.php	Updates test mocks to use specific request classes instead of generic Request
src/Http/Resources/*.php	Adds new API resource classes for subscribe, unsubscribe, validation errors, and base functionality
src/Http/Requests/*.php	Adds form request classes with validation rules and custom error handling
src/Http/ExpoController.php	Refactors controller methods to use form requests and API resources
composer.json	Adds dependency on ronasit/laravel-helpers package

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[coveralls]

Pull Request Test Coverage Report for Build 19215259525

Details

• 22 of 22 (100.0%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+1.2%) to 78.472%

---

Totals
Change from base Build 17207573500:	1.2%
Covered Lines:	113
Relevant Lines:	144

---

💛 - Coveralls

[Copilot]

Pull Request Overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

migrations/create_exponent_push_notification_interests_table.php.stub:26

• The up() and down() methods are missing return type declarations. For consistency with modern Laravel conventions and the test migration at tests/database/migrations/2014_10_12_000000_create_users_table.php (lines 9 and 18), these methods should declare : void as their return type.

    public function up()
    {
        Schema::create(config('exponent-push-notifications.interests.database.table_name'), function (Blueprint $table) {
            $table->increments('id');
            $table->string('key')->index();
            $table->string('value');

            $table->unique(['key','value']);
        });
    }

    /**
     * Reverse the migrations.
     */
    public function down()

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[DenTray]

why we can't use https://github.com/RonasIT/laravel-exponent-push-notifications/blob/68b7f0b8f66c63b7abcacc93dc7652c07225a3ef/migrations/create_exponent_push_notification_interests_table.php.stub in tests?

[DenTray]

not sure we need extra fields in the users table for tests

Suggested change

	$table->string('email')->unique();
	$table->timestamps();

[DenTray]

do we need it for the just abstract class?