[feature] Add goalkeeper or bot subst. intend change to ui protocol

Author: g3force

internal/app/controller/teamConnection.go

@@ -60,8 +60,12 @@ func (c *GameController) ProcessTeamRequests(teamName string, request refproto.T
 	}
 
 	if x, ok := request.GetRequest().(*refproto.TeamToControllerRequest_SubstituteBot); ok {
-		log.Printf("Team %v updated bot substituation intend to %v", team, x.SubstituteBot)
-		c.Engine.State.TeamState[team].BotSubstitutionIntend = x.SubstituteBot
+		if c.Engine.State.TeamState[team].BotSubstitutionIntend != x.SubstituteBot {
+			log.Printf("Team %v updated bot substituation intend to %v", team, x.SubstituteBot)
+			c.Engine.State.TeamState[team].BotSubstitutionIntend = x.SubstituteBot
+			c.Engine.LogTeamBotSubstitutionChange(team, x.SubstituteBot)
+		}
+		return nil
 	}
 
 	if c.Engine.State.GameState() != GameStateStopped {
@@ -73,6 +77,7 @@ func (c *GameController) ProcessTeamRequests(teamName string, request refproto.T
 			return errors.Errorf("Goalkeeper id is invalid: %v", x.DesiredKeeper)
 		}
 		log.Printf("Changing keeper for team %v to %v", team, x.DesiredKeeper)
+		c.Engine.LogTeamGoalkeeperChange(team, c.Engine.State.TeamState[team].Goalkeeper, int(x.DesiredKeeper))
 		c.Engine.State.TeamState[team].Goalkeeper = int(x.DesiredKeeper)
 	}
 

internal/app/controller/uiProtocol.go

@@ -23,6 +23,8 @@ const (
 	UiProtocolGameEventIgnored UiProtocolType = "ignoredGameEvent"
 	// UiProtocolModify represents a manual modification on the state
 	UiProtocolModify UiProtocolType = "modify"
+	// UiProtocolTeamAction represents an action from a team
+	UiProtocolTeamAction UiProtocolType = "teamAction"
 )
 
 // UiProtocolEntry represents a single protocol entry as should be displayed in the UI table
@@ -125,3 +127,31 @@ func (e *Engine) LogModify(m EventModifyValue) {
 	}
 	e.UiProtocol = append(e.UiProtocol, entry)
 }
+
+// LogTeamGoalkeeperChange adds a goalkeeper change from a team to the protocol
+func (e *Engine) LogTeamGoalkeeperChange(forTeam Team, oldGoalkeeperId int, newGoalkeeperId int) {
+	description := fmt.Sprintf("%v -> %v", oldGoalkeeperId, newGoalkeeperId)
+	entry := UiProtocolEntry{
+		Timestamp:   e.TimeProvider().UnixNano(),
+		StageTime:   e.State.StageTimeElapsed,
+		Type:        UiProtocolTeamAction,
+		Name:        "Goalkeeper",
+		Team:        forTeam,
+		Description: description,
+	}
+	e.UiProtocol = append(e.UiProtocol, entry)
+}
+
+// LogTeamBotSubstitutionChange adds a bot substitution intend change from a team to the protocol
+func (e *Engine) LogTeamBotSubstitutionChange(forTeam Team, substituteBot bool) {
+	description := fmt.Sprintf("%v", substituteBot)
+	entry := UiProtocolEntry{
+		Timestamp:   e.TimeProvider().UnixNano(),
+		StageTime:   e.State.StageTimeElapsed,
+		Type:        UiProtocolTeamAction,
+		Name:        "BotSubstitutionIntend",
+		Team:        forTeam,
+		Description: description,
+	}
+	e.UiProtocol = append(e.UiProtocol, entry)
+}