Use QUOTE_MINIMAL by default (#32)

Author: jeffreylovitz

redisgraph_bulk_loader/bulk_insert.py

@@ -57,7 +57,7 @@ def process_entities(entities):
 @click.option('--enforce-schema', '-d', default=False, is_flag=True, help='Enforce the schema described in CSV header rows')
 @click.option('--skip-invalid-nodes', '-s', default=False, is_flag=True, help='ignore nodes that use previously defined IDs')
 @click.option('--skip-invalid-edges', '-e', default=False, is_flag=True, help='ignore invalid edges, print an error message and continue loading (True), or stop loading after an edge loading failure (False)')
-@click.option('--quote', '-q', default=3, help='the quoting format used in the CSV file. QUOTE_MINIMAL=0,QUOTE_ALL=1,QUOTE_NONNUMERIC=2,QUOTE_NONE=3')
+@click.option('--quote', '-q', default=0, help='the quoting format used in the CSV file. QUOTE_MINIMAL=0,QUOTE_ALL=1,QUOTE_NONNUMERIC=2,QUOTE_NONE=3')
 # Buffer size restrictions
 @click.option('--max-token-count', '-c', default=1024, help='max number of processed CSVs to send per query (default 1024)')
 @click.option('--max-buffer-size', '-b', default=2048, help='max buffer size in megabytes (default 2048)')

redisgraph_bulk_loader/entity_file.py

@@ -137,7 +137,7 @@ def __init__(self, filename, label, config):
 
         # Initialize CSV reader that ignores leading whitespace in each field
         # and does not modify input quote characters
-        self.reader = csv.reader(self.infile, delimiter=config.separator, skipinitialspace=True, quoting=config.quoting)
+        self.reader = csv.reader(self.infile, delimiter=config.separator, skipinitialspace=True, quoting=config.quoting, escapechar='\\')
 
         self.packed_header = b''
         self.binary_entities = []

test/test_bulk_loader.py

@@ -562,7 +562,7 @@ def test13_id_namespaces(self):
 
         with open('/tmp/relations.tmp', mode='w') as csv_file:
             out = csv.writer(csv_file)
-            out.writerow([':START_ID(User), :END_ID(Post)'])
+            out.writerow([':START_ID(User)', ':END_ID(Post)'])
             out.writerow([0, 0])
             out.writerow([1, 1])