refactor(auth tests): simplify auth test cases using BaseAuthTestCase.

- Introduce BaseAuthTestCase to handle common setup/teardown logic:
  - Predefine authentication-related URLs (signup, signin, protected, refresh)
  - Clean up User, BlacklistedToken and OutstandingToken records after tests
- Remove redundant setUp()/tearDown() methods in individual test classes
- Replace hardcoded reverse() calls with inherited URL attributes
- Improve test maintainability through centralized configuration

This refactoring follows DRY principles and makes test code more focused on actual test scenarios rather than boilerplate setup.

Author: RandomProgramm3r

promo_code/user/tests/auth/base.py

@@ -0,0 +1,22 @@
+import django.urls
+import rest_framework.test
+import rest_framework_simplejwt.token_blacklist.models as tb_models
+
+import user.models
+
+
+class BaseAuthTestCase(rest_framework.test.APITestCase):
+    @classmethod
+    def setUpTestData(cls):
+        super().setUpTestData()
+        cls.client = rest_framework.test.APIClient()
+        cls.protected_url = django.urls.reverse('api-core:protected')
+        cls.refresh_url = django.urls.reverse('api-user:token_refresh')
+        cls.signup_url = django.urls.reverse('api-user:sign-up')
+        cls.signin_url = django.urls.reverse('api-user:sign-in')
+
+    def tearDown(self):
+        user.models.User.objects.all().delete()
+        tb_models.BlacklistedToken.objects.all().delete()
+        tb_models.OutstandingToken.objects.all().delete()
+        super().tearDown()

promo_code/user/tests/auth/test_authentication.py

@@ -4,41 +4,10 @@
 import rest_framework.test
 
 import user.models
+import user.tests.auth.base
 
 
-class AuthenticationTests(rest_framework.test.APITestCase):
-    def setUp(self):
-        self.client = rest_framework.test.APIClient()
-        super().setUp()
-
-    def tearDown(self):
-        user.models.User.objects.all().delete()
-        super().tearDown()
-
-    def test_valid_registration(self):
-        data = {
-            'name': 'Steve',
-            'surname': 'Jobs',
-            'email': 'minecraft.digger@gmail.com',
-            'password': 'SuperStrongPassword2000!',
-            'other': {'age': 23, 'country': 'gb'},
-        }
-        response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
-            data,
-            format='json',
-        )
-        self.assertEqual(
-            response.status_code,
-            rest_framework.status.HTTP_200_OK,
-        )
-        self.assertIn('access', response.data)
-        self.assertTrue(
-            user.models.User.objects.filter(
-                email='minecraft.digger@gmail.com',
-            ).exists(),
-        )
-
+class AuthenticationTests(user.tests.auth.base.BaseAuthTestCase):
     def test_signin_success(self):
         user.models.User.objects.create_user(
             email='minecraft.digger@gmail.com',

promo_code/user/tests/auth/test_registration.py

@@ -1,19 +1,11 @@
-import django.urls
 import rest_framework.status
 import rest_framework.test
 
 import user.models
+import user.tests.auth.base
 
 
-class RegistrationTests(rest_framework.test.APITestCase):
-    def setUp(self):
-        self.client = rest_framework.test.APIClient()
-        super().setUp()
-
-    def tearDown(self):
-        user.models.User.objects.all().delete()
-        super().tearDown()
-
+class RegistrationTests(user.tests.auth.base.BaseAuthTestCase):
     def test_registration_success(self):
         valid_data = {
             'name': 'Emma',
@@ -23,7 +15,7 @@ def test_registration_success(self):
             'other': {'age': 23, 'country': 'us'},
         }
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             valid_data,
             format='json',
         )

promo_code/user/tests/auth/test_tokens.py

@@ -1,37 +1,27 @@
-import django.test
-import django.urls
 import rest_framework.status
 import rest_framework.test
 import rest_framework_simplejwt.token_blacklist.models as tb_models
 
 import user.models
+import user.tests.auth.base
 
 
-class JWTTests(rest_framework.test.APITestCase):
+class JWTTests(user.tests.auth.base.BaseAuthTestCase):
     def setUp(self):
-        self.signup_url = django.urls.reverse('api-user:sign-up')
-        self.signin_url = django.urls.reverse('api-user:sign-in')
-        self.protected_url = django.urls.reverse('api-core:protected')
-        self.refresh_url = django.urls.reverse('api-user:token_refresh')
+        super().setUp()
         user.models.User.objects.create_user(
             name='John',
             surname='Doe',
             email='example@example.com',
             password='SuperStrongPassword2000!',
             other={'age': 25, 'country': 'us'},
         )
+
         self.user_data = {
             'email': 'example@example.com',
             'password': 'SuperStrongPassword2000!',
         }
 
-        super(JWTTests, self).setUp()
-
-    def tearDown(self):
-        user.models.User.objects.all().delete()
-
-        super(JWTTests, self).tearDown()
-
     def test_access_protected_view_with_valid_token(self):
         response = self.client.post(
             self.signin_url,

promo_code/user/tests/auth/test_validation.py

@@ -1,21 +1,12 @@
-import django.test
-import django.urls
 import parameterized
 import rest_framework.status
 import rest_framework.test
 
 import user.models
+import user.tests.auth.base
 
 
-class RegistrationTestCase(rest_framework.test.APITestCase):
-    def setUp(self):
-        self.client = rest_framework.test.APIClient()
-        super().setUp()
-
-    def tearDown(self):
-        user.models.User.objects.all().delete()
-        super().tearDown()
-
+class RegistrationTestCase(user.tests.auth.base.BaseAuthTestCase):
     def test_email_duplication(self):
         valid_data = {
             'name': 'Emma',
@@ -25,7 +16,7 @@ def test_email_duplication(self):
             'other': {'age': 23, 'country': 'us'},
         }
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             valid_data,
             format='json',
         )
@@ -42,7 +33,7 @@ def test_email_duplication(self):
             'other': {'age': 14, 'country': 'fr'},
         }
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             duplicate_data,
             format='json',
         )
@@ -60,7 +51,7 @@ def test_invalid_email_format(self):
             'other': {'age': 23, 'country': 'us'},
         }
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             data,
             format='json',
         )
@@ -91,7 +82,7 @@ def test_weak_password_cases(self, case_name, password):
         }
 
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             data,
             format='json',
         )
@@ -127,7 +118,7 @@ def test_invalid_avatar_urls(self, name, url, email):
         }
 
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             data,
             format='json',
         )
@@ -147,7 +138,7 @@ def test_missing_country_field(self):
             'other': {'age': 23},
         }
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             data,
             format='json',
         )
@@ -156,6 +147,30 @@ def test_missing_country_field(self):
             rest_framework.status.HTTP_400_BAD_REQUEST,
         )
 
+    def test_invalid_country_code(self):
+        invalid_data = {
+            'name': 'Emma',
+            'surname': 'Thompson',
+            'email': 'test.invalid.country@example.com',
+            'password': 'SuperStrongPassword2000!',
+            'other': {
+                'age': 23,
+                'country': 'XX',
+            },
+        }
+
+        response = self.client.post(
+            self.signup_url,
+            invalid_data,
+            format='json',
+        )
+
+        self.assertEqual(
+            response.status_code,
+            rest_framework.status.HTTP_400_BAD_REQUEST,
+            'Invalid country code should trigger validation error',
+        )
+
     def test_invalid_age_type(self):
         data = {
             'name': 'Emma',
@@ -165,7 +180,7 @@ def test_invalid_age_type(self):
             'other': {'age': '23aaaaaa', 'country': 'us'},
         }
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             data,
             format='json',
         )
@@ -183,7 +198,7 @@ def test_missing_age_field(self):
             'other': {'country': 'us'},
         }
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             data,
             format='json',
         )
@@ -201,7 +216,7 @@ def test_negative_age_value(self):
             'other': {'age': -20, 'country': 'us'},
         }
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             data,
             format='json',
         )
@@ -228,7 +243,7 @@ def test_invalid_email_formats(self, name, email):
         }
 
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             data,
             format='json',
         )
@@ -248,7 +263,7 @@ def test_empty_name_field(self):
             'other': {'age': 23, 'country': 'us'},
         }
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             data,
             format='json',
         )
@@ -267,7 +282,7 @@ def test_empty_surname_field(self):
             'other': {'age': 23, 'country': 'us'},
         }
         response = self.client.post(
-            django.urls.reverse('api-user:sign-up'),
+            self.signup_url,
             data,
             format='json',
         )
@@ -277,16 +292,7 @@ def test_empty_surname_field(self):
         )
 
 
-class AuthenticationTestCase(rest_framework.test.APITestCase):
-    def setUp(self):
-        self.client = rest_framework.test.APIClient()
-        self.signin_url = django.urls.reverse('api-user:sign-in')
-        super().setUp()
-
-    def tearDown(self):
-        user.models.User.objects.all().delete()
-        super().tearDown()
-
+class AuthenticationTestCase(user.tests.auth.base.BaseAuthTestCase):
     @parameterized.parameterized.expand(
         [
             ('missing_password', {'email': 'valid@example.com'}, 'password'),
@@ -321,7 +327,7 @@ def test_signin_invalid_password(self):
             'password': 'SuperInvalidPassword2000!',
         }
         response = self.client.post(
-            django.urls.reverse('api-user:sign-in'),
+            self.signin_url,
             data,
             format='json',
         )