Revamp testing.

[neoblizz]

No description provided.

[Copilot]

Pull request overview

This PR revamps the testing infrastructure to improve test organization and execution. The key changes include consolidating workflow files, adding support for separate test directories (examples, unittests, ccl), and improving test isolation through explicit preamble calls in all_reduce tests.

Key Changes

• Consolidated testing workflows into a single comprehensive iris-tests.yml file with a matrix strategy that tests each directory (examples, unittests, ccl) with different rank counts (1, 2, 4, 8)
• Updated test scripts to accept a test directory parameter, enabling more granular test execution
• Enhanced all_reduce tests to explicitly call preamble before running operations for better test isolation

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
.github/workflows/iris-tests.yml	New consolidated workflow with matrix strategy for testing all directories across multiple GPU configurations
.github/workflows/iris-tests-apptainer.yml	Deleted old Apptainer-specific workflow, functionality now in iris-tests.yml
.github/workflows/iris-pip-install-test.yml	Deleted pip installation test workflow, consolidated into main testing workflow
.github/workflows/iris-performance-regression-test.yml	Added DOCKER_IMAGE_NAME environment variable for consistency
.github/workflows/iris-external-validation-test.yml	Added DOCKER_IMAGE_NAME environment variable for consistency
.github/scripts/run_tests.sh	Enhanced to accept test directory parameter and validate directory existence
.github/scripts/container_run.sh	Updated to use DOCKER_IMAGE_NAME variable with fallback to "iris-dev"
.github/scripts/container_exec.sh	Updated to use DOCKER_IMAGE_NAME variable with fallback to "iris-dev"
.github/scripts/container_build.sh	Updated to use DOCKER_IMAGE_NAME variable with fallback to "iris-dev"
tests/ccl/test_all_reduce.py	Disabled "ring" variant testing and added explicit preamble calls for better test isolation

[Copilot]

Dead code: The conditional block for the "ring" variant will never execute since "ring" has been commented out in the parametrize decorator above (line 19). Consider removing this block or uncommenting the "ring" variant in the test parameters.

Suggested change

	if variant == "ring":
	config.all_reduce_num_rings = min(2, config.comm_sms)

[Copilot]

Missing documentation: The "ring" variant is commented out without explanation. Consider adding a comment explaining why this variant is disabled (e.g., "# ring - disabled due to known issues" or "# ring - TODO: fix compatibility issues").

Suggested change

	# "ring",
	# "ring", # Disabled due to known issues with the ring algorithm (TODO: fix compatibility issues)

[mawad-amd]

I would like us to continue testing against the three different installs:

• pip install git+https://github.com/${{ github.repository }}.git@${{ github.sha }}
• pip install -e .
• pip install .

Sometimes source structure and import assumptions are only captured in one vs the other.

[neoblizz]

@mawad-amd why don't we just make sure the installs work there?

[mawad-amd]

Just pip install without running the tests you mean?

[mawad-amd]

There are issues that won't show up unless we actually run the tests. If we really have to test against one and do some smoke tests against the other, then I would prefer we always do the full test suite against pip install git+https://github.com/${{ github.repository }}.git@${{ github.sha }}

[mawad-amd]

Looks great and much cleaner. Thanks!