From f9fb5a4d79450763d0d925f81878deb85df2ba97 Mon Sep 17 00:00:00 2001
From: Battleplus <121445871+Battleplus@users.noreply.github.com>
Date: Fri, 21 Aug 2026 10:27:05 +0800
Subject: [PATCH 1/2] fix: migrate tmaze to vecenv.h

---
 ocean/tmaze/binding.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/ocean/tmaze/binding.c b/ocean/tmaze/binding.c
index e4ccf7d887..efaf29363e 100644
--- a/ocean/tmaze/binding.c
+++ b/ocean/tmaze/binding.c
@@ -1,17 +1,21 @@
 #include "tmaze.h"
 
+#define OBS_SIZE 4
+#define NUM_ATNS 1
+#define ACT_SIZES {3}
+#define OBS_TENSOR_T ByteTensor
+
 #define Env TMaze
-#include "../env_binding.h"
+#include "vecenv.h"
 
-static int my_init(Env* env, PyObject* args, PyObject* kwargs) {
-    env->size = unpack(kwargs, "size");
-    return 0;
+void my_init(Env* env, Dict* kwargs) {
+    env->size = dict_get(kwargs, "size", 15);
+    allocate_TMaze(env);
 }
 
-static int my_log(PyObject* dict, Log* log) {
-    assign_to_dict(dict, "perf", log->perf);
-    assign_to_dict(dict, "score", log->score);
-    assign_to_dict(dict, "episode_return", log->episode_return);
-    assign_to_dict(dict, "episode_length", log->episode_length);
-    return 0;
+void my_log(Log* log, Dict* out) {
+    dict_set(out, "perf", log->perf);
+    dict_set(out, "score", log->score);
+    dict_set(out, "episode_return", log->episode_return);
+    dict_set(out, "episode_length", log->episode_length);
 }

From 35a6b3095f0e012748c564b8c924b8bd81f281de Mon Sep 17 00:00:00 2001
From: Battleplus <121445871+Battleplus@users.noreply.github.com>
Date: Fri, 21 Aug 2026 16:29:07 +0800
Subject: [PATCH 2/2] fix(tmaze): complete ABI migration to vecenv.h
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Add required num_agents and rng fields to TMaze struct.
Change actions/terminals from int*/uchar* to float* to match
vecenv.h buffer ownership. Remove allocate_TMaze from my_init
since vecenv manages observation/action/reward/terminal buffers.
Fix dict_get call to use ->value accessor (2-arg API).
Cast float actions to int in c_step for discrete action handling.

Fixes #542 (tmaze environment only)

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
---
 ocean/tmaze/binding.c |  4 ++--
 ocean/tmaze/tmaze.c   |  8 ++++----
 ocean/tmaze/tmaze.h   | 12 +++++++-----
 3 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/ocean/tmaze/binding.c b/ocean/tmaze/binding.c
index efaf29363e..fd191d7b73 100644
--- a/ocean/tmaze/binding.c
+++ b/ocean/tmaze/binding.c
@@ -9,8 +9,8 @@
 #include "vecenv.h"
 
 void my_init(Env* env, Dict* kwargs) {
-    env->size = dict_get(kwargs, "size", 15);
-    allocate_TMaze(env);
+    env->size = (int)dict_get(kwargs, "size")->value;
+    env->num_agents = 1;
 }
 
 void my_log(Log* log, Dict* out) {
diff --git a/ocean/tmaze/tmaze.c b/ocean/tmaze/tmaze.c
index a6c8f277c0..9d302bf313 100644
--- a/ocean/tmaze/tmaze.c
+++ b/ocean/tmaze/tmaze.c
@@ -8,12 +8,12 @@ int main() {
     c_render(&env);
     while (!WindowShouldClose()) {
         if (IsKeyDown(KEY_LEFT_SHIFT)) {
-            env.actions[0] = FORWARD;
-            if (IsKeyDown(KEY_LEFT)  || IsKeyDown(KEY_A)) env.actions[0] = LEFT;
-            if (IsKeyDown(KEY_RIGHT) || IsKeyDown(KEY_D)) env.actions[0] = RIGHT;
+            env.actions[0] = (float)FORWARD;
+            if (IsKeyDown(KEY_LEFT)  || IsKeyDown(KEY_A)) env.actions[0] = (float)LEFT;
+            if (IsKeyDown(KEY_RIGHT) || IsKeyDown(KEY_D)) env.actions[0] = (float)RIGHT;
 
         } else {
-            env.actions[0] = rand() % 3;
+            env.actions[0] = (float)(rand() % 3);
         }
         c_step(&env);
         c_render(&env);
diff --git a/ocean/tmaze/tmaze.h b/ocean/tmaze/tmaze.h
index 618e7d29ba..0e5eb89a9a 100644
--- a/ocean/tmaze/tmaze.h
+++ b/ocean/tmaze/tmaze.h
@@ -27,11 +27,13 @@ typedef struct {
 typedef struct {
     Log log; // Required field. Env binding code uses this to aggregate logs
     unsigned char* observations; // Required. You can use any obs type, but make sure it matches in Python!
-    int* actions; // Required. int* for discrete/multidiscrete, float* for box
+    float* actions; // Required. float* to match vecenv.h allocation
     float* rewards; // Required
-    unsigned char* terminals; // Required. We don't yet have truncations as standard yet
+    float* terminals; // Required. float* to match vecenv.h allocation
     int size; // length of the corridor
     int tick;
+    int num_agents; // Required by vecenv.h default my_vec_init
+    unsigned int rng; // Required by vecenv.h default my_vec_init
 
     unsigned char state; // Internal current position in the maze
     unsigned char starting_state; // Starting state (2 or 3)
@@ -42,9 +44,9 @@ typedef struct {
 
 TMaze* allocate_TMaze(TMaze *env) {
     env->observations = calloc(4, sizeof(unsigned char));
-    env->actions = calloc(1, sizeof(int));
+    env->actions = calloc(1, sizeof(float));
     env->rewards = calloc(1, sizeof(float));
-    env->terminals = calloc(1, sizeof(unsigned char));
+    env->terminals = calloc(1, sizeof(float));
     return env;
 }
 
@@ -99,7 +101,7 @@ void c_step(TMaze* env) {
     env->terminals[0] = 0;
     env->rewards[0] = 0;
 
-    int action = env->actions[0];
+    int action = (int)env->actions[0];
 
     if (env->state == env->size -1) {
         const int left_reward = (env->starting_state == 2) ? 1 : -1;